Breaking change: Remove MutableRepeatedFieldRef::Reserve() in reflection (roll forward) #1112
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_707633413
branch
from
December 18, 2024 22:39
7173fde to
cbb0067
Compare
copybara-service
Bot
changed the title
MutableRepeatedFieldRef::Reserve() (reflection), reduxMutableRepeatedFieldRef::Reserve() (reflection), attempt 2
copybara-service
Bot
force-pushed
the
test_707633413
branch
from
December 20, 2024 22:26
cbb0067 to
b196f84
Compare
copybara-service
Bot
changed the title
MutableRepeatedFieldRef::Reserve() (reflection), attempt 2MutableRepeatedFieldRef::Reserve() in reflection (roll forward)
…ction (roll forward) An upcoming performance improvement in RepeatedPtrField is incompatible with this API. The improvement is projected to accelerate repeated access to the elements of `RepeatedPtrField`, in particular and especially sequential access. PA: https://protobuf.dev/news/2024-12-13/ PiperOrigin-RevId: 708439051
copybara-service
Bot
force-pushed
the
test_707633413
branch
from
December 20, 2024 23:10
b196f84 to
c441502
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change: Remove
MutableRepeatedFieldRef::Reserve()in reflection (roll forward)An upcoming performance improvement in RepeatedPtrField is incompatible with this API. The improvement is projected to accelerate repeated access to the elements of
RepeatedPtrField, in particular and especially sequential access.PA: https://protobuf.dev/news/2024-12-13/