fix(models): raise ValueError instead of assert in Gemma model check - #7356
Open
chelsealong wants to merge 1 commit into
Open
chelsealong wants to merge 1 commit into
chelsealong wants to merge 1 commit into
Conversation
assert is stripped under python -O, so the non-Gemma model guard vanished.
1 of 4 tasks
MateehUllah
reviewed
Oct 1, 2026
MateehUllah
left a comment
MateehUllah
left a comment
There was a problem hiding this comment.
Reviewed this against #7355. Replacing the runtime assert with an explicit ValueError addresses the reported python -O / -OO behavior, since the model-family guard is no longer stripped by optimization.
The updated negative-model test also correctly checks the new exception type. I don't see a correctness issue with the change.
One optional improvement would be adding an optimization-mode regression test, but the implementation itself directly fixes the underlying issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7355
Gemma.generate_content_async()validated the model family withassert, which is stripped underpython -O. It now raisesValueError(matching the repo's "No Asserts in Production Code" guidance). The existingtest_not_gemma_modelis updated to expectValueError.Testing:
1 failed, 25 passed(test_not_gemma_modelhit theAssertionErrorat gemma_llm.py:255).26 passed(pytest tests/unittests/models/test_gemma_llm.py).AI assistance: drafted with Claude Code; reviewed and tested by the author.