Skip to content

fix: return structured tool error when a required path param is missing #7352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aniketkrs wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −0
Open

fix: return structured tool error when a required path param is missing #7352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/google/adk/tools/openapi_tool/openapi_spec_parser/rest_api_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

import logging
import ssl
import string
from typing import Any
from typing import Callable
from typing import Dict
Expand Down Expand Up @@ -460,6 +461,19 @@ def _prepare_request_params(
# Construct URL
base_url = self.endpoint.base_url or ""
base_url = base_url[:-1] if base_url.endswith("/") else base_url
# Fail closed with a structured, retryable tool error when a required
# path placeholder was not provided: str.format() would otherwise
# raise an uncaught KeyError that aborts the whole agent invocation.
missing_path_params = [
field_name
for _, field_name, _, _ in string.Formatter().parse(self.endpoint.path)
if field_name and field_name not in path_params
]
if missing_path_params:
raise InputValidationError(
f"Missing required path parameter(s) {missing_path_params} for path"
f" template '{self.endpoint.path}'."
)
url = f"{base_url}{self.endpoint.path.format(**path_params)}"

# Move query params embedded in the path template itself (now that path
Expand Down
Loading