Repository navigation
Conversation
…sh in Dockerfile generation for Cloud Run deployments
This commit introduces a new test case for the `to_cloud_run` function in `cli_deploy.py`. The new test, `test_to_cloud_run_with_requirements_sh`, specifically verifies that if a `requirements.sh` file is present in my source directory, the generated Dockerfile includes a command to execute this script. The `agent_dir` fixture has been updated to support the creation of a dummy `requirements.sh` file for testing purposes.
feat: Add test for requirements.sh in cli_deploy
Collaborator
|
Hi @runa and thanks to everyone who participated in this thread. We're currently doing some housekeeping on our pull request queue. Given the rapid pace of development and the number of updates since this was last active, there's a good chance this pull request needs to be caught up to the latest version. To help us keep our backlog focused on current pull requests, we are closing this as stale. If you're still interested in contributing to this change, could you please update to the very latest version of the library and create a new pull request? Our team will be glad to help with the refreshed PRs and answer any questions! Thanks for your contribution and understanding! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I implemented OS-level dependencies for Cloud Run deployments; dependencies that cannot be satisfied by using
pip install -r requirements.txt(for example, installing Node or installing a TypeScript MCP server, etc.).I implemented similarly to the Python dependencies: if
requirements.shexists, the Dockerfile will run it.See also #1473