Initial implementation of the json parser #7
Closed
Naddiseo wants to merge 1 commit into
Closed
Conversation
Owner
|
Awesome! I would like to merge this into the json branch instead of master for testing. Can you re-issue the pull request to the json branch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds initial support for the json response type from intuit. It adds a objectifier class which lazily converts the json response into objects.
One other change is the tag pattern regex for converting camelCase to underscore_case, I changed it to take into account "401K" which originally was being converted to "401_k", and now is converted to "401k".
I've only written basic tests to make sure the objectifier adheres to the same interface as the original xml implementation
Partial fix for #6