Skip to content

Commit 1079d63

Browse files
author
John Kinsella
committed
Summary: Prevent deletion of wrong iptables rules
Detail: A grep in security_group.py wasn't defined well enough, could potentially delete rules for VMs other than intended BUG-ID: CLOUDSTACK-309 Bugfix-for: master Reviewed-by: Reported-by: Francois Scala Signed-off-by: John Kinsella <[email protected]> 1363222521 -0700
1 parent 381f737 commit 1079d63

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

scripts/vm/network/security_group.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,7 @@ def post_default_network_rules(vm_name, vm_id, vm_ip, vm_mac, vif, brname, dhcpS
344344
def delete_rules_for_vm_in_bridge_firewall_chain(vmName):
345345
vm_name = vmName
346346
if vm_name.startswith('i-') or vm_name.startswith('r-'):
347-
vm_name = '-'.join(vm_name.split('-')[:-1])
347+
vm_name = '-'.join(vm_name.split('-')[:-1]) + "-def"
348348

349349
vmchain = vm_name
350350

0 commit comments

Comments
 (0)