Address review feedback about config section casing

codex · Byron · commit 5252136d9b5a · 2026-07-20T11:10:51.000+02:00
Review feedback: Git accepts core section names case-insensitively, while GitConfigParser preserves section casing and the hook lookup only inspected a literal core section.

Aggregate options from every section whose name case-folds to core before selecting the effective hooksPath value. Extend the regression configuration to use mixed casing for both the section and option names.
diff --git a/git/index/fun.py b/git/index/fun.py
@@ -67,7 +67,9 @@ def hook_path(name: str, git_dir: PathLike) -> str:
 def _commit_hook_path(name: str, index: "IndexFile") -> str:
     """:return: path to the named commit hook, respecting Git's core.hooksPath."""
     with index.repo.config_reader() as config:
-        core_items = config.items("core") if config.has_section("core") else []
+        core_items = [
+            item for section in config.sections() if section.lower() == "core" for item in config.items(section)
+        ]
         hooks_dir = next((value for option, value in reversed(core_items) if option.lower() == "hookspath"), None)
 
     if not hooks_dir:
diff --git a/test/test_index.py b/test/test_index.py
@@ -1206,7 +1206,7 @@ def test_pre_commit_hook_respects_core_hooks_path(self, rw_repo):
         os.chmod(hp, 0o744)
 
         with index.repo.config_writer() as writer:
-            writer.set_value("core", "HoOkSpAtH", "custom-hooks")
+            writer.set_value("CoRe", "HoOkSpAtH", "custom-hooks")
 
         index.commit("This should run the custom hook")
         output = Path(rw_repo.working_dir, "custom-hook-output.txt").read_text(encoding="utf-8")
