Who should merge a PR?

Who should merge the PR and therefore approve not only the changes, but the deployment at this moment as well?

Side notes:

We do not use feature flags (yet).
Sometimes we need to deploy a feature only after certain event/time despite the feature being complete.
We don't want master (for deployments), develop (to base new work) and feature branches, just a simple structure of master and feature branches.

Right now we are using the following workflow:

A developer opens a PR.
A colleague approves the changes.
The person who has opened the PR should merge when he sees fit, because he is the one who should know best when this should land on production.

However if a feature is ready and reviewed, but should not be deployed for quite some time we are left with an open PR which just hangs there.

Do you think tagging could help?

Navigation Menu