Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Adding git fetch button - #74

Merged
StanleyGoldman merged 6 commits into
masterfrom
features/git-fetch-button
Jul 5, 2017
Merged

StanleyGoldman merged 6 commits into
masterfrom
features/git-fetch-button

Conversation

@StanleyGoldman

Copy link
Copy Markdown
Contributor

Fixes: #73

var fetchClicked = GUILayout.Button(FetchButtonText, Styles.HistoryToolbarButtonStyle);
GUI.enabled = true;
if (fetchClicked &&
EditorUtility.DisplayDialog(FetchConfirmTitle,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't need to ask for confirmation, fetch is a non-destructive operation, we can just do it.

@shana shana left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a little comment regarding the confirmation dialog (don't think we need it for non-destructive operations like fetch), otherwise 👍

@StanleyGoldman
StanleyGoldman merged commit 8629a70 into master Jul 5, 2017
@StanleyGoldman
StanleyGoldman deleted the features/git-fetch-button branch July 5, 2017 19:59
shana added a commit that referenced this pull request Jul 6, 2017
StanleyGoldman added a commit that referenced this pull request Jul 6, 2017
@StanleyGoldman StanleyGoldman modified the milestone: 0.16 Sep 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants