This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Repository navigation
Moving ReadOnlyCollection to a different namespace - #65
Merged
Merged
Conversation
StanleyGoldman
force-pushed
the
fixes/readonlycollection-collision
branch
from
June 29, 2017 21:40
ddc1df1 to
8fe2277
Compare
StanleyGoldman
commented
Jun 30, 2017
| <AssemblyName>GitHub.Api</AssemblyName> | ||
| <TargetFrameworkVersion>v3.5</TargetFrameworkVersion> | ||
| <FileAlignment>512</FileAlignment> | ||
| <SolutionType Condition="$(SolutionName)=='GitHub.Unity.Internal'">Internal</SolutionType> |
Contributor
Author
There was a problem hiding this comment.
Part one of the trick
StanleyGoldman
commented
Jun 30, 2017
| </ItemGroup> | ||
| <Choose> | ||
| <When Condition="$(SolutionType) == 'Internal'"> | ||
| <ItemGroup> |
Contributor
Author
There was a problem hiding this comment.
Part two of the trick
Member
|
Renamed the solution to Replaced the octokit and threading dlls with mono-built ones to get the symbol files when running with Unity. Moved the custom targets out to separate files so VS doesn't keep screwing up the formatting. |
shana
force-pushed
the
fixes/readonlycollection-collision
branch
from
July 3, 2017 13:22
976d2ae to
0a36fc9
Compare
VS loves to screw around with the csproj format, so move all the custom rules into separate files that it can't screw around with. This also gives the added benefit of shutting up the warning about duplicate AssemblyVersionInformation types, because apparently VS doesn't show files that are included for compilation from external targets files but it still includes them in the compilation (bug? feature? shrug) Add instructions for the GitHub.Unity.OctokitDebugging solution Add mono-built versions of octokit and dotnet-http. Octokit: 0.23.0.1 dotnet-httpClient35: 3.5.0.0 (3.5.22000.1-gfu)
shana
force-pushed
the
fixes/readonlycollection-collision
branch
from
July 3, 2017 13:25
0a36fc9 to
e8ff209
Compare
shana
approved these changes
Jul 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64
Fixes: #69
GitHub.Unity.Internalthat expects to find dependent repos as siblings to this repo, their names should be the same as their repositoriesGitHub.Unity.Internalthey set a flag