add cli - #1
Closed
bhenderson wants to merge 1 commit into
Closed
Conversation
Author
|
just for fun, I added some args processing: https://gist.github.com/3009374 |
Author
|
nm. |
mislav
added a commit
that referenced
this pull request
Feb 18, 2015
Rewrite with a more efficient algorithm
kivikakk
pushed a commit
that referenced
this pull request
Feb 7, 2018
fca9ae5 "avoid signed overflow" can still cause undefined behavior because `compare_version_number` can return `INT_MIN` which `version_compare_cb_r` then tries to negate: ``` ../../../../ext/version_sorter/version_sorter.c:94:9: runtime error: negation of -2147483648 cannot be represented in type 'int'; cast to an unsigned type to negate this value to itself #0 0x7f9cde1fe1ba in version_compare_cb_r /tmp/x86_64-linux-gnu/version_sorter/2.3.1/../../../../ext/version_sorter/version_sorter.c:94:9 #1 0x7f9cde75c231 (/lib/x86_64-linux-gnu/libc.so.6+0x39231) #2 0x7f9cde75c69e in qsort_r (/lib/x86_64-linux-gnu/libc.so.6+0x3969e) #3 0x7f9cde1fd68c in rb_version_sort_1 /tmp/x86_64-linux-gnu/version_sorter/2.3.1/../../../../ext/version_sorter/version_sorter.c:202:2 ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there, I know this project is super old, but I stumbled upon the github blogpost about it and I thought it was pretty awesome. I hacked together a quick bin which seems to do mostly all I want. It's really simple with no cli args.
I didn't update the gemspec as I don't know if that's like updating the version.rb file. (I'm also not familiar with jeweller).
What do you think?
thanks,