Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: github/version_sorter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: github/version_sorter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2-0-stable
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 16 commits
  • 6 files changed
  • 5 contributors

Commits on Oct 6, 2017

  1. Change StringValuePtr to StringValueCStr

    StringValuePtr doesn't guarantee a NULL byte at the end of the char * it
    returns.  The for loop in the `parse_version_number` depends on a NULL
    byte in the string in order to stop the loop.  Since `StringValuePtr`
    doesn't guarantee a NULL byte in the `char *`, it's possible the for
    loop could read past the end of the string, and `offset` would end up
    being larger than the number of bytes that are actually in the string.
    tenderlove committed Oct 6, 2017
    Configuration menu
    Copy the full SHA
    1f7545d View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2017

  1. Configuration menu
    Copy the full SHA
    56d0cd0 View commit details
    Browse the repository at this point in the history
  2. Support for old Rubygems in tests

    This fixes the test on Rubygems 1.8.23.2
    mislav committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    43fd2a3 View commit details
    Browse the repository at this point in the history
  3. Avoid Bundler bug on Travis

    mislav committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    086592c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    adb1793 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5351df0 View commit details
    Browse the repository at this point in the history
  6. Update version in Gemfile.lock

    mislav committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    9349b9a View commit details
    Browse the repository at this point in the history
  7. version_sorter 2.0.1

    mislav committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    9be73b1 View commit details
    Browse the repository at this point in the history
  8. Add release script

    mislav committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    7df1df2 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2018

  1. correctly shift 64 bit values

    kivikakk authored and mislav committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    ccc5f59 View commit details
    Browse the repository at this point in the history
  2. version_sorter 2.0.2

    mislav committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    5f1c671 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2018

  1. avoid signed overflow

    kivikakk committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    4f47c85 View commit details
    Browse the repository at this point in the history
  2. Clamp comparisons to -1, 0, 1

    fca9ae5 "avoid signed overflow" can still cause undefined behavior because
    `compare_version_number` can return `INT_MIN` which `version_compare_cb_r`
    then tries to negate:
    
    ```
    ../../../../ext/version_sorter/version_sorter.c:94:9: runtime error: negation of -2147483648 cannot be represented in type 'int'; cast to an unsigned type to negate this value to itself
        #0 0x7f9cde1fe1ba in version_compare_cb_r /tmp/x86_64-linux-gnu/version_sorter/2.3.1/../../../../ext/version_sorter/version_sorter.c:94:9
        #1 0x7f9cde75c231  (/lib/x86_64-linux-gnu/libc.so.6+0x39231)
        #2 0x7f9cde75c69e in qsort_r (/lib/x86_64-linux-gnu/libc.so.6+0x3969e)
        #3 0x7f9cde1fd68c in rb_version_sort_1 /tmp/x86_64-linux-gnu/version_sorter/2.3.1/../../../../ext/version_sorter/version_sorter.c:202:2
    ```
    philipturnbull authored and kivikakk committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    ff48c44 View commit details
    Browse the repository at this point in the history
  3. add int negate test

    kivikakk committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    8d8b1fa View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2018

  1. memory fixes from #17

    kivikakk committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    0faa512 View commit details
    Browse the repository at this point in the history
  2. version_sorter 2.0.3

    kivikakk committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    f27d85b View commit details
    Browse the repository at this point in the history
Loading