-
Notifications
You must be signed in to change notification settings - Fork 35
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: github/version_sorter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: github/version_sorter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2-0-stable
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 16 commits
- 6 files changed
- 5 contributors
Commits on Oct 6, 2017
-
Change StringValuePtr to StringValueCStr
StringValuePtr doesn't guarantee a NULL byte at the end of the char * it returns. The for loop in the `parse_version_number` depends on a NULL byte in the string in order to stop the loop. Since `StringValuePtr` doesn't guarantee a NULL byte in the `char *`, it's possible the for loop could read past the end of the string, and `offset` would end up being larger than the number of bytes that are actually in the string.
Configuration menu - View commit details
-
Copy full SHA for 1f7545d - Browse repository at this point
Copy the full SHA 1f7545dView commit details
Commits on Oct 13, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 56d0cd0 - Browse repository at this point
Copy the full SHA 56d0cd0View commit details -
Support for old Rubygems in tests
This fixes the test on Rubygems 1.8.23.2
Configuration menu - View commit details
-
Copy full SHA for 43fd2a3 - Browse repository at this point
Copy the full SHA 43fd2a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 086592c - Browse repository at this point
Copy the full SHA 086592cView commit details -
Configuration menu - View commit details
-
Copy full SHA for adb1793 - Browse repository at this point
Copy the full SHA adb1793View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5351df0 - Browse repository at this point
Copy the full SHA 5351df0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9349b9a - Browse repository at this point
Copy the full SHA 9349b9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9be73b1 - Browse repository at this point
Copy the full SHA 9be73b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7df1df2 - Browse repository at this point
Copy the full SHA 7df1df2View commit details
Commits on Jan 29, 2018
-
Configuration menu - View commit details
-
Copy full SHA for ccc5f59 - Browse repository at this point
Copy the full SHA ccc5f59View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f1c671 - Browse repository at this point
Copy the full SHA 5f1c671View commit details
Commits on Feb 7, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 4f47c85 - Browse repository at this point
Copy the full SHA 4f47c85View commit details -
fca9ae5 "avoid signed overflow" can still cause undefined behavior because `compare_version_number` can return `INT_MIN` which `version_compare_cb_r` then tries to negate: ``` ../../../../ext/version_sorter/version_sorter.c:94:9: runtime error: negation of -2147483648 cannot be represented in type 'int'; cast to an unsigned type to negate this value to itself #0 0x7f9cde1fe1ba in version_compare_cb_r /tmp/x86_64-linux-gnu/version_sorter/2.3.1/../../../../ext/version_sorter/version_sorter.c:94:9 #1 0x7f9cde75c231 (/lib/x86_64-linux-gnu/libc.so.6+0x39231) #2 0x7f9cde75c69e in qsort_r (/lib/x86_64-linux-gnu/libc.so.6+0x3969e) #3 0x7f9cde1fd68c in rb_version_sort_1 /tmp/x86_64-linux-gnu/version_sorter/2.3.1/../../../../ext/version_sorter/version_sorter.c:202:2 ```
Configuration menu - View commit details
-
Copy full SHA for ff48c44 - Browse repository at this point
Copy the full SHA ff48c44View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d8b1fa - Browse repository at this point
Copy the full SHA 8d8b1faView commit details
Commits on Feb 12, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 0faa512 - Browse repository at this point
Copy the full SHA 0faa512View commit details -
Configuration menu - View commit details
-
Copy full SHA for f27d85b - Browse repository at this point
Copy the full SHA f27d85bView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...2-0-stable