[BUG]: eval "$(gh copilot alias -- bash)" takes 0.5 second to load #88

Activity

1. yermulnik

   added

   bugSomething isn't workingSomething isn't working

   needs-triageneeds to be reviewedneeds to be reviewed

   on Jul 9, 2024
2. jarrodldavis commented on Nov 20, 2024

   

   jarrodldavis

   on Nov 20, 2024

   More actions

   I have the same issue using eval "$(gh copilot alias -- zsh)" on macOS. Strangely, the entire script to be evaluated is emitted instantly, it's just that the gh command takes a long time to exit.
3. BagToad commented on Nov 20, 2024

   

   BagToad

   on Nov 20, 2024

   Member

   More actions

   I suspect this actually has more to do with gh startup time than the gh-copilot extension - see cli/cli#9724

   @yermulnik @jarrodldavis, could you try setting TCELL_MINIMIZE=1 and let us know if that improves the performance?
4. jarrodldavis commented on Nov 20, 2024

   

   jarrodldavis

   on Nov 20, 2024

   More actions

   @BagToad That helped performance a bit, but only reduced from 0.11s to 0.07s (according to time). As I noted initially, the issue is after the script is emitted, suggesting that it's an issue with the exit time, not the startup time. Additionally, I notice this slow exit consistently across all gh copilot commands (even gh copilot --help), but the root gh command is fast.
5. yermulnik commented on Nov 20, 2024

   

   yermulnik

   on Nov 20, 2024

   Author

   More actions

   > export TCELL_MINIMIZE=1
   > time eval "$(gh copilot alias -- bash)"
   
   real    0m1,250s
   user    0m0,167s
   sys     0m0,080s
   
   # second run
   > time eval "$(gh copilot alias -- bash)"
   
   real    0m1,116s
   user    0m0,120s
   sys     0m0,037s

   🤔
6. BagToad commented on Nov 20, 2024

   

   BagToad

   on Nov 20, 2024

   Member

   More actions

   Ah, thanks for trying that out! Sounds like we have more investigating to do 😁
7. pmeheut commented on Jan 16, 2025

   

   pmeheut

   on Jan 16, 2025

   Last edited by pmeheut

   More actions

   Same problem here and even slower in my good old Macpro: 1.7 sec. Ok, it is only a 12 core 3.3 Ghz Xeon but still: nothing it that slow.

   In the meantime, I've decided to cache it each day, commenting the line out and adding this to my .bashrc:

   # Define the path to the .ghrc file
   GHRC_PATH="$HOME/.ghrc"
   
   # Check if the file exists and is older than 1 day
   if [[ ! -f "$GHRC_PATH" || $(find "$GHRC_PATH" -mtime +0 -print) ]]; then
     echo "Updating .ghrc file..."
     gh copilot alias -- bash > "$GHRC_PATH"
   fi
   
   # Evaluate the content of the .ghrc file
   if [[ -f "$GHRC_PATH" ]]; then
     echo "Evaluating .ghrc file..."
     source "$GHRC_PATH"
   else
     echo "Error: .ghrc file not found after update."
     exit 1
   fi
   
8. GriwMF commented on Jan 18, 2025

   

   GriwMF

   on Jan 18, 2025

   Last edited by GriwMF

   More actions

   Have the same issue with bash in Arch under wsl

   ~ $ time eval "$(gh copilot alias -- bash)"
   
   real    0m1.267s
   user    0m0.052s
   sys     0m0.040s
   

   ~ $ export TCELL_MINIMIZE=1
   ~ $ time eval "$(gh copilot alias -- bash)"
   
   real    0m1.253s
   user    0m0.075s
   sys     0m0.028s
   ~ $
   

   As a temporary fix I did
   gh copilot alias -- bash > .bash_copilot_aliases
   and then loaded it in my .bashrc

   # load .bash_copilot_aliases if it exists
   if [ -f ~/.bash_copilot_aliases ]; then
       . ~/.bash_copilot_aliases
   fi