Validate change-notes as a PR check - #4116
Open
mario-campos wants to merge 5 commits into
Open
mario-campos wants to merge 5 commits into
mario-campos wants to merge 5 commits into
Conversation
Contributor
Author
|
Closing this to re-work these changes after a migration to the |
mario-campos
marked this pull request as draft
September 11, 2026 02:58
mario-campos
force-pushed
the
mario-campos/validate-cn-workflow
branch
from
September 11, 2026 03:07
f2789ac to
ef0cd9e
Compare
mbg
reviewed
Sep 11, 2026
mario-campos
force-pushed
the
mario-campos/validate-cn-workflow
branch
from
September 11, 2026 19:35
17bb097 to
b652468
Compare
mario-campos
force-pushed
the
mario-campos/validate-cn-workflow
branch
from
September 11, 2026 19:52
b652468 to
21b6978
Compare
mario-campos
force-pushed
the
mario-campos/validate-cn-workflow
branch
2 times, most recently
from
September 11, 2026 21:00
425de06 to
c4bd5c9
Compare
This commit also introduces the 'empty' home directory for future change-notes.
mario-campos
force-pushed
the
mario-campos/validate-cn-workflow
branch
from
September 11, 2026 21:04
c4bd5c9 to
f60f4d9
Compare
mbg
previously approved these changes
Sep 14, 2026
mbg
left a comment
Member
There was a problem hiding this comment.
This LGTM, with two non-blocking suggestions for improvements.
Also, slightly improve the log statement of the validation error case.
…oteFiles` The `isValidAllChangenoteFiles` now accepts a list of file paths rather than a file path string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the behavior of the recently added
pr-checks/changenotes.mtstool by:unreleased-change-notesdirectory, as that is the only destination for change-notes.pr-checks.ymlworkflow file for executingpr-checks/changenotes.mtsin PRs to validate any changenotes inunreleased-change-notes.This PR also introduces an "empty" top-level directory,
unreleased-change-notes, to be the destination of future change-note files. This can be changed if another location is more suitable.Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
Products:
Environments:
How did/will you validate this change?
.test.tsfiles).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist