fix: persist inputs between the upload action and its post step#2557
Conversation
Co-authored-by: Josh Soref <[email protected]>
NlightNFotis
changed the title
jsoref
left a comment
jsoref
left a comment
There was a problem hiding this comment.
Looks good to me. Tested it https://github.com/check-spelling-sandbox/check-spelling/actions/runs/11439466596/job/31823193138 and it worked. (The patch partially failed to apply because the source map wasn't a match to the version included in the runner cache, but that isn't a requirement -- and when I was doing my testing, I didn't include the source map file.)
Note that there are four actions that use post:. If I were maintaining this repository, I'd patch all of them otherwise, there's a risk that someone else gets tripped up that this only works in some code paths...
|
@NlightNFotis can you cherry-pick d9886b8 ? VSCode automatically wanted to remove that whitespace... |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Hm, I want to do that, but I get ❯ git cherry-pick d9886b85848afc58f19094c760535a6dd1a8cf77
fatal: bad object d9886b85848afc58f19094c760535a6dd1a8cf77I think the original branch with this change has been deleted, so it cannot find the commit. I also looked into your fork and I cannot find the branch there. Would it be possible to extract it as a patch and post it here as a comment? @jsoref |
NlightNFotis
force-pushed
the
persist-inputs
branch
from
9230370 to
bd02c19
Compare
Signed-off-by: Josh Soref <[email protected]>
|
@jsoref Done! Thanks again for your time and effort helping us get to a good state in our code! Your input is greatly appreciated. |
henrymercer
left a comment
henrymercer
left a comment
There was a problem hiding this comment.
I am not sure whether this is happening due to a bug or an intended omission in the mechanisms for passing inputs, but the fix LGTM.
…toreState callsites. Co-authored-by: Henry Mercer <[email protected]> Co-authored-by: Fotis Koutoulakis <[email protected]>
NlightNFotis
force-pushed
the
persist-inputs
branch
from
edc874a to
9bc4ee1
Compare
|
@henrymercer Thank you for the review, I have integrated all of the changes in 9bc4ee1. Would you please have another look at this one? |
henrymercer
left a comment
henrymercer
left a comment
There was a problem hiding this comment.
Thanks @jsoref, @chrisgavin, and @NlightNFotis!
5 participants
Description
This PR is fixing an issue with persisting action inputs between steps of the runner. This is an issue that is downstream of a problem with the GitHub Actions runner, ref: actions/runner#3514
Closes #2553
Merge / deployment checklist
readme).inputhandling for post steps #2554, an alternative fix for the original issue)Acknowledgments