C#: Remove splitting-awareness from data flow.#21473
Open
aschackmull wants to merge 9 commits intogithub:mainfrom
Open
C#: Remove splitting-awareness from data flow.#21473aschackmull wants to merge 9 commits intogithub:mainfrom
aschackmull wants to merge 9 commits intogithub:mainfrom
Conversation
aschackmull
added
the
no-change-note-required
aschackmull
force-pushed
the
csharp/dataflow-no-split
branch
from
59e0041 to
591f9d7
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the C#-specific “splitting-aware” control-flow reachability layer previously used to constrain local data-flow/taint steps, simplifying the internal C# data-flow implementation now that splitting is largely gone.
Changes:
- Deleted
dataflow/internal/ControlFlowReachability.qlland removed its imports/uses across internal data-flow and taint tracking. - Replaced reachability-configuration–based stepping with direct local step predicates and simplified reverse post-update handling.
- Updated
config/identical-files.jsonto drop the “C# ControlFlowReachability” identical-files group.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| csharp/ql/lib/semmle/code/csharp/dataflow/internal/TaintTrackingPrivate.qll | Removes dependency on splitting-aware reachability and simplifies local taint expression stepping and post-update reverse steps. |
| csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowPrivate.qll | Removes reachability configuration scaffolding; refactors local flow/argument/store/read/lambda logic to not rely on splitting-aware reachability. |
| csharp/ql/lib/semmle/code/csharp/dataflow/internal/ControlFlowReachability.qll | Deletes the splitting-aware control-flow reachability helper module used by internal data-flow. |
| csharp/ql/consistency-queries/DataFlowConsistency.ql | Updates post-update node handling to match the refactored LocalFlow reverse-step API. |
| config/identical-files.json | Removes the identical-files entry tying the deleted file to its rangeanalysis counterpart. |
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that splitting has been (almost) eradicated from C#, the code that makes C# data flow splitting-aware has become superfluous.