C++: Modernize PrintIR for local dataflow#13266
Merged
Merged
Conversation
…owSteps) after the use-use flow changes.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| string nodeId(DataFlow::Node node, int order1, int order2) { | ||
| exists(Instruction instruction | instruction = node.asInstruction() | | ||
| result = instruction.getResultId() and | ||
| string nodeId(Node node, int order1, int order2) { |
Check warning
Code scanning / CodeQL
Missing QLDoc for parameter
jketema
approved these changes
May 24, 2023
Contributor
jketema
left a comment
jketema
left a comment
There was a problem hiding this comment.
This seems to change the behaviour somewhat, e.g., no reference to any configuration anymore, but given that the alternative was to completely delete this internal, I'm not to worried about this, and it's always something we can add back later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PrintIRLocalFlow.qllfile had bit-rotted quite a bit since no one was really using it, and after #13260 was merged it's the only remaining old-style dataflow configuration in the C/C++ library.I had this PR lying around locally which updated the
PrintIRLocalFlow.qllfile (and related files) after the use-use flow changes, and coincidentally it also removed the old-style dataflow configuration.cc @jketema