Skip to content

Added basic timing around the ghe-restore process - #625

Merged
cjonsmith merged 3 commits into
github:masterfrom
herbenderbler:add-ghe-restore-timing
Aug 11, 2020
Merged

Added basic timing around the ghe-restore process#625
cjonsmith merged 3 commits into
github:masterfrom
herbenderbler:add-ghe-restore-timing

Conversation

@herbenderbler

Copy link
Copy Markdown
Contributor

This PR adds basic timing output around the ghe-restore process, per the request from Issue #529

@cainejette

Copy link
Copy Markdown
Contributor

Awesome, thank you!

@herbenderbler

herbenderbler commented Aug 2, 2020

Copy link
Copy Markdown
Contributor Author

@cainejette My PR is failing on linters, which are throwing errors on code I didn't change. How do I run these linters locally against my branch?

@cainejette

cainejette commented Aug 4, 2020

Copy link
Copy Markdown
Contributor

My PR is failing on linters

That shouldn't be a required step, so you should be clear from that perspective. Although we realize now that the action wasn't set up properly to trigger on PRs from forks and are addressing it in #628

If you push a commit after that goes in, will that trigger the two required build steps?

@herbenderbler

Copy link
Copy Markdown
Contributor Author

If you push a commit after that goes in, will that trigger the two required build steps?

Yes. It seems to pass the macos-latest step, but it fails on ubuntu-latest and Lint Code Base.

The former error seems to be because of an outdated URI for downloading shellcheck and the latter appears to fail on Markdown linting errors unrelated to my PR.

@cainejette

Copy link
Copy Markdown
Contributor

The former error seems to be because of an outdated URI for downloading shellcheck

This is also being fixed in #628

the latter appears to fail on Markdown linting errors unrelated to my PR.

This can be ignored

@herbenderbler

Copy link
Copy Markdown
Contributor Author

@cainejette So can someone merge this or is there something else I need to do for this PR to go green?

@cainejette

Copy link
Copy Markdown
Contributor

can someone merge this

Yep! We will see it through. Thanks for contributing!

@cjonsmith
cjonsmith merged commit 5fe3243 into github:master Aug 11, 2020
@cjonsmith

Copy link
Copy Markdown
Contributor

Merged! Sorry for the delay, and thanks again for the contribution 😄

@herbenderbler
herbenderbler deleted the add-ghe-restore-timing branch September 7, 2020 22:56
@jianghao0718 jianghao0718 changed the title Added basic timing around the ghe-restore process Added Basic Timing Around the ghe-restore Process Sep 23, 2020
@jianghao0718 jianghao0718 changed the title Added Basic Timing Around the ghe-restore Process Added basic timing around the ghe-restore process Sep 23, 2020
This was referenced Sep 23, 2020
dooleydevin pushed a commit that referenced this pull request Oct 2, 2023
…orkflow-build-release-part-2

Backport 568 for 3.7: Build and Release Workflow Part 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants