Restoring to an un-configured appliance fails due to a missing license file - #449
Merged
Conversation
lildude
approved these changes
Nov 8, 2018
Merged
dooleydevin
added a commit
that referenced
this pull request
Jul 25, 2023
…t-create-current-encryption-key-backup-3.7.0+ Backport 443 for 3.8: Kyfast create current encryption key backup 3.7.0+
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When restoring to an un-configured appliance,
ghe-restoreis unable to progress past theghe-restore-storagestep. The restore of storage data fails because thestorage-cluster-restore-routesscript on the appliance is unable to connect to the MySQL database.ghe-restore verbose output
We first see something going wrong when the message
Error: no license file found (/data/user/common/enterprise.ghl)is shown. This corresponds with an earlyghe-single-config-applytermination recorded in theghe-config.logon the appliance:It appears the error is a result of the license file being restored after
ghe-restore-settingsimports the new config and executesghe-single-config-apply --phase-1. As theghe-single-config-applyrun is incomplete, the GitHub environment is not properly populated with SQL credentials.This PR alters the order of operations to introduce the license file to the appliance before attempting to import and apply the configuration.
I also noted while reproducing this issue that if the hostname is specified as the first argument to
ghe-restore, that all subsequent flags are ignored. I've included a fix to work around that use case as well./cc @github/backup-utils