Skip to content

Add missing dependencies to debian packaging - #418

Merged
lildude merged 1 commit into
github:masterfrom
reddit:add-missing-deps
Jul 18, 2018
Merged

Add missing dependencies to debian packaging#418
lildude merged 1 commit into
github:masterfrom
reddit:add-missing-deps

Conversation

@spladug

@spladug spladug commented Jul 17, 2018

Copy link
Copy Markdown
Contributor

jq and sponge (from moreutils) were getting caught by the test suite
failing during package build. Adding these to both build-depends and
depends fixes the problem at build time and later install time.

jq and sponge (from moreutils) were getting caught by the test suite
failing during package build. Adding these to both build-depends and
depends fixes the problem at build time and later install time.
@djdefi
djdefi requested a review from lildude July 17, 2018 22:57

@lildude lildude left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. We completely missed this as our build and test systems already have these pkgs installed.

Thanks for the PR.

@lildude
lildude merged commit 29fbd3c into github:master Jul 18, 2018
@lildude lildude added the bug label Aug 7, 2018
@lildude lildude mentioned this pull request Aug 7, 2018
@nsheaps
nsheaps deleted the add-missing-deps branch October 14, 2022 00:14
@nsheaps
nsheaps restored the add-missing-deps branch October 14, 2022 00:15
@nsheaps
nsheaps deleted the add-missing-deps branch October 14, 2022 00:15
dooleydevin added a commit that referenced this pull request Jul 21, 2023
…/boxofyellow/2023-06/mssql-backup_0

Backport 348 for 3.8: Allow the caller to handle setting failures
@dooleydevin dooleydevin mentioned this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants