Remove -o option from ps use - #341
Merged
Merged
Conversation
snh
suggested changes
Sep 29, 2017
| snapshot=$(echo "$progress" | cut -d ' ' -f 1) | ||
| pid=$(echo "$progress" | cut -d ' ' -f 2) | ||
| if ! ps -p $pid -o command= | grep ghe-backup; then | ||
| if ! ps -p $pid -o command= 2>/dev/null | grep ghe-backup; then |
Member
There was a problem hiding this comment.
It'd be good if we could still provide protection against multiple simultaneous backups to those who lack -o support.
As an alternative, could we drop the use of -o altogether?
if ! ps -p $pid | grep ghe-backup; then
Contributor
Author
|
@snh I've removed the |
snh
approved these changes
Oct 3, 2017
snh
left a comment
snh
left a comment
Member
There was a problem hiding this comment.
Looks good! I ran some quick tests on a Stretch box running this branch and it behaved as expected when an existing backup was still underway as well as when the in-progress file was stale.
Merged
pluehne
pushed a commit
to pluehne/backup-utils
that referenced
this pull request
Aug 8, 2023
Remove ghe-prune-snapshots from ghe-backup so it can be called separately. Incremental logic handling to be done outside of this PR.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #260, this is another instance where
psuses the-oflag. This PR follows the same fix as before and redirects any error to/dev/null./cc @github/backup-utils