Some fixes - #1972
Merged
Merged
Conversation
Signed-off-by: Johannes Schindelin <[email protected]>
We are using that pattern all over the place, and unless an attacker gets write access to the `gitgitgadget/git` repository (in which case there are much easier ways to wreak havoc than to go through GitGitGadget), there is no way to inject anything. Signed-off-by: Johannes Schindelin <[email protected]>
Just a couple of indentation/formatting fixes. Signed-off-by: Johannes Schindelin <[email protected]>
`npm` pointed out that: npm warn deprecated @types/[email protected]: This is a stub types definition. json-stable-stringify provides its own type definitions, so you do not need this installed. npm warn deprecated @types/[email protected]: This is a stub types definition. marked provides its own type definitions, so you do not need this installed. Signed-off-by: Johannes Schindelin <[email protected]>
Member
Author
|
@webstech I hope to be moving fast on these changes (as well as a couple of others, including one that will unbreak the Azure Pipelines after I merged #1473...). If you're available, I would appreciate timely reviews, but if this is an inopportune time for you, don't worry (I'll want to move relatively fast before my own availability dwindles again, hope you don't mind!). |
Member
Author
|
@webstech thanks!
TBH I think this might just be a change in ESLint, I didn't manage to keep up with it ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working towards a GitHub Action, I noticed a couple of issues that are really easy to resolve.