Update Unity part 2#195
Merged
Merged
Conversation
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sequel to #194
binarytolfsby default, as discussedeol=lfattribute for YAML files that I replaced withtextin the last PR by mistakeAssets/Plugins). There's one issue with this however. Users need to actually put their plugins into this folder. For example, TextMesh Pro gets imported directly underAssetsby default, and some people just leave it there. Storing these third-party assets under thePluginsdirectory is a popular convention that some assets in the Asset Store do by default (e.g. DOTween), so I only included this folder so we don't have to specify popular plugins in the gitattributes one by one. Also, since TextMesh Pro's default folder name has a space in it, it would have to be defined like this:Assets/TextMesh[[:space:]]Pro/** linguist-vendored, which just looks bad imo.