Skip to content

migrate to Go Module, use official compiler for cross-compiling - #28

Merged
CatTail merged 3 commits into
git-hooks:masterfrom
QuantumGhost:master
Dec 2, 2019
Merged

migrate to Go Module, use official compiler for cross-compiling#28
CatTail merged 3 commits into
git-hooks:masterfrom
QuantumGhost:master

Conversation

@QuantumGhost

Copy link
Copy Markdown
Contributor

No description provided.

- Migrate to Go Module
- Upgrade dependencies
- Fix incorrect types in code
- Use Go's native cross compiling mechanism
@QuantumGhost
QuantumGhost force-pushed the master branch 2 times, most recently from bb0e4b5 to 2b9dc26 Compare November 21, 2019 13:22
@QuantumGhost QuantumGhost changed the title WIP: migrate to Go Module, use official compiler for cross-compiling migrate to Go Module, use official compiler for cross-compiling Nov 21, 2019

@CatTail CatTail left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for improving this project, the PR looks good to me with minor comments. Ignore the CircleCI failure, I will disable that check.

Comment thread Makefile
Comment thread Makefile Outdated
Comment thread Readme.md

## Supported Go versions

git-hooks supports the latest two Go version. (Currently 1.12 and 1.13)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually implementation details right? final user, which will use the binary directly do not care about which go version we use for development.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users may want to install git-hooks via go get, so I guess it's better to keep it.

Comment thread cli.go
We do not support Go 1.11 since [md2man](github.com/cpuguy83/go-md2man/v2/md2man)
requires Go 1.12+.
@CatTail
CatTail merged commit 4bf2e03 into git-hooks:master Dec 2, 2019
CatTail added a commit that referenced this pull request Apr 21, 2026
migrate to Go Module, use official compiler for cross-compiling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants