Skip to content

sanatize errors from terminal control characters - #5

Merged
MichaelMure merged 1 commit into
masterfrom
sanatize-errors
Oct 10, 2026
Merged

MichaelMure merged 1 commit into
masterfrom
sanatize-errors

Conversation

@MichaelMure

@MichaelMure MichaelMure commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

Fix the new Windows test failures before merging.

Findings

  1. P1 Windows tests fail ▶

Summary

This PR removes ASCII control bytes other than tab and newline from error messages.

  • Gitconfig error messages replace terminal control characters with question marks.

Reviews (1) · Last reviewed commit: "sanatize errors from terminal control ch..." · Reviewed by Greptile

Comment thread errors_test.go Outdated

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MichaelMure has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MichaelMure has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@MichaelMure
MichaelMure merged commit a27fcee into master Oct 10, 2026
3 checks passed
@MichaelMure
MichaelMure deleted the sanatize-errors branch October 10, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant