Skip to content

feature: Github bridge mutation rate limit - #694

Merged
rng-dynamics merged 5 commits into
masterfrom
dev-github-bridge
Sep 14, 2021
Merged

rng-dynamics merged 5 commits into
masterfrom
dev-github-bridge

Conversation

@rng-dynamics

Copy link
Copy Markdown
Contributor

I wrote a new struct client which handles all the calls to the Github GraphQL API and which deals with the rate limit in a single place.

Note: work in progress; some manual testing is still needed.

@rng-dynamics rng-dynamics linked an issue Jul 4, 2021 that may be closed by this pull request
@MichaelMure

Copy link
Copy Markdown
Contributor

Cool stuff!

@rng-dynamics
rng-dynamics marked this pull request as ready for review July 11, 2021 15:01
@rng-dynamics

Copy link
Copy Markdown
Contributor Author

@MichaelMure: If you have any suggestions I would be happy to implement them. I linked issue #315, because it should be fixed with this pull request.

@MichaelMure

Copy link
Copy Markdown
Contributor

hey @rng-dynamics, sorry for the delay. Life is super busy but should be back to normal-ish in a month.

@rng-dynamics

Copy link
Copy Markdown
Contributor Author

no problem

@rng-dynamics

Copy link
Copy Markdown
Contributor Author

@MichaelMure I would need someones approval to merge.

@6543 6543 added this to the 0.8.0 milestone Sep 13, 2021

@6543 6543 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per #706

@6543

6543 commented Sep 13, 2021

Copy link
Copy Markdown
Contributor

@rng-dynamics wana merge?

@rng-dynamics
rng-dynamics merged commit 247e1a8 into master Sep 14, 2021
@rng-dynamics
rng-dynamics deleted the dev-github-bridge branch September 14, 2021 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub bridge doesnt' handle mutation API rate limit

3 participants