Skip to content

Bridge: correctly emit NothingEvents - #254

Merged
MichaelMure merged 4 commits into
masterfrom
import-events
Nov 19, 2019
Merged

MichaelMure merged 4 commits into
masterfrom
import-events

Conversation

@a-hilaly

Copy link
Copy Markdown
Collaborator

fix #231

@MichaelMure
MichaelMure merged commit dcf3feb into master Nov 19, 2019
@MichaelMure
MichaelMure deleted the import-events branch November 19, 2019 20:13
@MichaelMure

Copy link
Copy Markdown
Contributor

CC @cheshirekow

@cheshirekow

cheshirekow commented Nov 23, 2019 •

Copy link
Copy Markdown
Contributor

CC @cheshirekow

Ok so I see that a lot of the NewExportNothing events are dropped in this review. I was definitely copying their current placement so whats the semantics of the NewExportNothing? Should it only be used when a whole bug cannot be imported? Should it not be used when a particular operation cannot be imported?

Edit: Oops, missed the issue #231 and also the discussion on my review #250. I get it now. Just one ImportNothing after going through all new remote data and only if none of them were imported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

import/export: the "nothing" event should be emitted only when nothing happen on a bug, not on an operation

3 participants