Repository navigation
Conversation
The New issue screen caps itself at max-w-3xl while the shell (and the issues list and issue detail pages it renders) uses max-w-screen-xl, so the form looks visibly narrower than the list it was opened from.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1640
The New issue screen wrapped its content in
mx-auto max-w-3xl, but the layout shell renders every page insidemx-auto max-w-screen-xl(seewebui/src/components/layout/shell.tsx). The issues list and the issue detail page fill that width, so the form opened from the list came out visibly narrower than it.Removing the extra cap makes the New issue screen match the issues list, which is what the issue asks for. The issue detail screen (
$id.tsx) has no width cap of its own, so it now lines up too.pnpm run check(oxlint + oxfmt) passes.
The PR appears safe to merge.Summary
Removes
mx-auto max-w-3xlfrom the new issue page so the form uses the shell width.Reviews (1) · Last reviewed commit: "webui: let the new issue form span the s..." · Reviewed by Greptile