Repository navigation
bridge: add a dedicated lock to avoid concurrent run - #1674
Open
MichaelMure wants to merge 1 commit into
Open
MichaelMure wants to merge 1 commit into
MichaelMure wants to merge 1 commit into
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
MichaelMure
force-pushed
the
bridge-lock
branch
from
October 6, 2026 14:34
5116296 to
0cae455
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR has no newly established blocking issue, but callers that abandon a result stream can still retain the bridge lock.
Findings
Summary
The PR adds a repository-wide file lock around bridge imports and exports, and closes the Launchpad importer’s event channel when its worker exits.
Diagram
%%{init: {'theme': 'neutral'}}%% flowchart LR A[Import or export requested] --> B{Acquire bridge.lock} B -- Already exists --> C[Return ErrBridgeRunning] B -- Acquired --> D[Run bridge and relay events] D --> E[Result stream finishes] E --> F[Release bridge.lock]Reviews (2) · Last reviewed commit: "bridge: add a dedicated lock to avoid co..."