Repository navigation
Multiple bugs with gitlab bridge. #366
Description
Hi,
Playing with git-bug on a existing gitlab repository with a few existing issues on the vendor's bug tracker, I ran trough the following errors:
After having successfully configured the bridge I could import the gitlab issues as well as creating a couple of local issues with git bug add, so far so good. Then, I meet the following errors:
- when doing again
git bug bridge pull, issues are duplicated with new hashes. - nothing is exported when doing
git bug bridge push, it jus returnsexported 0 issues with myBridge bridge.
I've tested the bridge on a freshly created repo on gitlab, again the first steps goes well, but this time when doing git bug bridge pull a second time to test if duplicates arise, I got this crash:
panic: runtime error: index out of range [-1]
goroutine 51 [running]:
github.com/MichaelMure/git-bug/bridge/gitlab/iterator.(*issueIterator).Value(...)
/home/dtrckd/src/_sink/git-bug/bridge/gitlab/iterator/issue.go:38
github.com/MichaelMure/git-bug/bridge/gitlab/iterator.(*Iterator).NextIssue(0xc0010ba000, 0xc000043dd0)
/home/dtrckd/src/_sink/git-bug/bridge/gitlab/iterator/iterator.go:86 +0x244
github.com/MichaelMure/git-bug/bridge/gitlab.(*gitlabImporter).ImportAll.func1(0xc000260100, 0xc0000aed00, 0xc0010bc000)
/home/dtrckd/src/_sink/git-bug/bridge/gitlab/import.go:70 +0x547
created by github.com/MichaelMure/git-bug/bridge/gitlab.(*gitlabImporter).ImportAll
/home/dtrckd/src/_sink/git-bug/bridge/gitlab/import.go:66 +0x146
Similar scenario on Github seems to work fine.
Version:
git-bug version: 0.7.1-dev-28c3ee3b71
github.com/xanzy/go-gitlab v0.29.0
go version go1.14.1 linux/amd64
Gitlab: 12.9.2 (self hosted)
OS: Linux 4.19.0-8-amd64 / Debian 10 x86_64
Activity
dtrckd commentedon Apr 10, 2020
New test result:
When using git-bug bridge by pushing bugs to remote before pulling, bug are exported. Then If we create an issue on Gitlab and import, the first time import is ok, then I got the crash (+ the doublon), and bridge push doesn't push new local bug anymore.
gms8994 commentedon Apr 13, 2020
I've received this error as well. Create an identity locally, then followed these steps:
git bug bridge configure- set up gitlab as the bridgegit bug termui- notice that there are now two issues listed, one with the label, one without.Performing a pull from within
git bug termui"works," in thatdoneis reported.gms8994 commentedon Apr 13, 2020
This also seems to affect new instances of a gitlab bridge. After configuring in another repo, I attempted to
git bug bridge pulland received the samepanicas above.mkroehnert commentedon May 17, 2020
Hi, I am receiving the same
panic: runtime error: index out of range [-1]on the repo that I used for testing in #360.For reference:
git bug bridge pullwith git-bug 0.7.1 on the same checkout that held the initialgit bug bridge pullfrom the above mentioned ticket.MichaelMure commentedon May 18, 2020
Hey guys, sorry it's taking time. Life is busy at the moment...
mkroehnert commentedon May 21, 2020
@mkroehnert take your time.
I didn't post the example to pressure anyone but to contribute an example that hopefully helps in reproducing the issue.
stacyharper commentedon Jul 16, 2020
I think it is related to #378 cause it works perfectly when you add a first issue on gitlab.
Btw, there is any steps done about this gitlab gridge?
I'll close my other issue cause it is just a duplicate of this : #389
MichaelMure commentedon Jul 16, 2020
Not at the moment. I'm pretty busy on other parts of the code, on top of my actual job. If someone could step up and debug this that would be very welcome.
basxto commentedon Nov 1, 2020
I did not get an error, but duplicated issues and comments happen for me on github too.
All issues and comments created with
git bug, they got duplicated after pulling what I pushed before.The exporter does not push the duplicates again.
stacyharper commentedon Feb 8, 2021
Thanks for the fix on the importer !
It seems there is still a bug on the exporter, somehow.
Pushing new bug or comment or edition (or I think anything) still give
exported 0 issues with foobar bridge5nord commentedon Feb 8, 2021
I also noticed two issues:
git bug lsorgit bug termui).But those issues seem not to be related with the original importer issues and I have not figured the root cause, yet.
MichaelMure commentedon Feb 8, 2021
This is a known issue (although there is not one filed here). The problem is that the gitlab API changed and we don't have access to the history of state change anymore. See https://github.com/MichaelMure/git-bug/blob/master/bridge/gitlab/export_test.go#L245-L248
To be fair, it's not even a proper API. They call that "note", it's a sort of stream of untyped events. It was sort of enough at some point to get the full history of a bug but not anymore.
https://github.com/MichaelMure/git-bug/blob/master/bridge/gitlab/import_notes.go
One thing we could do is to create a status change in git-bug to match the final state, but that means we won't have the full history.
No idea about this one.
MichaelMure commentedon Feb 8, 2021
Well, that was 7 months ago, maybe the API changed again?
5nord commentedon Feb 8, 2021
Thank you for the context, Michael. I'll dig right into it. :-)
The GitLab issue API response seems to provide a
state: {open, closed}field: https://docs.gitlab.com/ce/api/issues.html#single-issue. I could not find any references to a history, yet. However, I could imagine a single state without explicit history is sufficient for most use cases.MichaelMure commentedon Feb 8, 2021
It would work (as in, you get the correct final state), but the history would be incorrect. That can be misleading and would definitely be seen as a bug.
5nord commentedon Feb 8, 2021
Maybe I am still missing a point. Are you talking about the issue history on gitlab side? Do git-bug bugs also have a history?
MichaelMure commentedon Feb 8, 2021
git-bug has the full history of a bug (you can see it in the timeline: you can see, say, all the status change, not just the current state). Ideally, an importer would be able to import this full history to mirror exactly what happened on the remote tracker. The github importer does that, the Jira one as well, but gitlab doesn't provide a good enough API ... (I'll say it, it's quite crap).
5nord commentedon Feb 9, 2021
I understand the issues with the GitLab API.
I might have an idea how to fix the missing history in gitlab importer: Since GitLab 13.2 there's a API for retrieving issue state changes. When xanzy/go-gitlab#1062 is accepted, I'd like to handle state changes similar to label changes.
If this also resolves any issue with exporting, I don't know, yet.
MichaelMure commentedon Feb 9, 2021
@5nord that's awesome! Any idea if a modern Gitlab also include new API to replace the usage of other "notes" we use in the importer? It works now but it's also quite unstable ...
5nord commentedon Feb 9, 2021
It looks like it. However, I am not sure, because I am still familiarizing with git-bug and GitLab API.
MichaelMure commentedon Feb 12, 2021
@5nord this is actually #435
MichaelMure commentedon Nov 20, 2022
Closing as a lot have changed in the bridges. Please open a new issue if there is still problems.