Conversation
Signed-off-by: Shubham Ghule <[email protected]>
Signed-off-by: Shubham Ghule <[email protected]>
…repository Signed-off-by: Shubham Ghule <[email protected]>
turn the fetch_if_missing into field of repositry made the relevant changes
|
Welcome, and thanks for working on this! It seems that there are quite a few merge conflicts, would you mind rebasing this to the current Please make sure that your commit message focuses on answering the question "why?" more than on "how?", and that it wraps at <= 76 columns per line. Also do make sure to add your sign off with a valid email address.
There is a strong preference for using the "imperative mood", please do use it in your commit messages. In general, you should find inspiration how to improve the commit messages here: https://git-scm.com/docs/SubmittingPatches#describe-changes Finally send the patch to the mailing list for review. You can use GitGitGadget, submitGit or send it manually. |
|
Whoa, now I am confused. I just realized that you opened a GitGitGadget PR at gitgitgadget#351, then closed it, only to open a PR here. But the Git project does not accept PRs. Only patch submissions via the Git mailing list. GitGitGadget owes its existence to the mission to help convert PRs to such submissions, so it is not at all clear why the GitGitGadget PR was closed, in favor of a Git PR (which will never be accepted). What's up with that, @dev-shubham1? |
|
@dev-shubham1 gentle ping? |
|
It actually looks as if the Git project pursues a different direction: getting rid of those assignments altogether (as they are not thread-safe). See e.g. fce9e83 |
|
@dev-shubham1 are you interested in this PR at all anymore? |
|
Imitate fce9e83, i.e. getting rid of |
|
@dev-shubham1 gentle ping? |
got rid of fetch_if_missing assignments as suggested.What next ? |
Force-push? |
OBJECT_INFO_SKIP_FETCH_OBJECT is also a global variable but the initial aim was to reduce global variables right ? |
No, it is a constant. The idea is that it is used in a Note: the |
|
Shall we close this in favor of gitgitgadget#606? |
|
Ya Sure |
ghost
closed this
Use federated authentication with GitHub Actions and Azure Entra ID for the Azure login commands during `build-git-installers.yml` builds. This will allow us to drop the use of a client secret to authenticate as the signing identity for Trusted Code Signing. The `AZURE_CLIENT_ID`, `AZURE_TENANT_ID`, and `AZURE_SUBSCRIPTION_ID` secrets have already been added to the `release` environment, and a test of the `azure/login` step using this mechanism and a subsequent `az` command has been successfully demonstrated here: https://github.com/microsoft/git/actions/runs/9652892561/job/26624014573
Use federated authentication with GitHub Actions and Azure Entra ID for the Azure login commands during `build-git-installers.yml` builds. This will allow us to drop the use of a client secret to authenticate as the signing identity for Trusted Code Signing. The `AZURE_CLIENT_ID`, `AZURE_TENANT_ID`, and `AZURE_SUBSCRIPTION_ID` secrets have already been added to the `release` environment, and a test of the `azure/login` step using this mechanism and a subsequent `az` command has been successfully demonstrated here: https://github.com/microsoft/git/actions/runs/9652892561/job/26624014573
2 participants
Hi GIT contributors !
I am Shubham Ghule.I have resolved the problem of extern integer fetch_if_missing by putting it in the structure repository as a field.Made the relevent changes suggested by @dscho.
I'm looking forward to your review.
Special thanks to @dscho.
with regards,
Shubham.