Skip to content

Documentation: fix typos for the reference in new-command.txt - #430

Closed
kyagi wants to merge 1 commit into
git:masterfrom
kyagi:fix-typo-api-builtin-txt-no-longer-exists
Closed

Documentation: fix typos for the reference in new-command.txt#430
kyagi wants to merge 1 commit into
git:masterfrom
kyagi:fix-typo-api-builtin-txt-no-longer-exists

Conversation

@kyagi

@kyagi kyagi commented Nov 9, 2017

Copy link
Copy Markdown

api-builtin.txt no longer exists. This change should have been done at ec14d4e

@submitgit

Copy link
Copy Markdown
Member

@kyagi sent this commit (7668cbc...13a7606) as a patch to the mailing list with submitGit - here on public-inbox, MARC

@dscho

dscho commented Jun 3, 2019

Copy link
Copy Markdown
Member

@kyagi hi! (And thank you for your patience.)

It would seem that your contribution may have been overlooked, most likely because

  1. it was not signed off, and
  2. its commit message left a bit to be desired.

With regards to the latter: the Git project usually insists on quite verbose commit messages that describe interesting information that is not readily deduced from reading the diff.

In your case, I would wager a guess that it would do wonders to add a paragraph that talks about how this document was introduced in 29ed548 (Documentation: how to add a new command, 2012-11-26), that there was an api-builtin.txt back then, and how ec14d4e (builtin.h: take over documentation from api-builtin.txt, 2017-08-02) got rid of that file, moving all the information directly into builtin.h.

That would convince e.g. me that this is a good change to have.

@dscho

dscho commented Jun 26, 2019

Copy link
Copy Markdown
Member

@kyagi ping?

@kyagi

kyagi commented Jun 27, 2019

Copy link
Copy Markdown
Author

@dscho hi! (And thank you for your response.)

You exactly got the point. I agree with your idea that a paragraph should be added to describe the document's history. I would appreciate if you could handle it accordingly. Thank you.

@dscho

dscho commented Jun 27, 2019

Copy link
Copy Markdown
Member

@kyagi Please understand that open source relies on contributors to be active, so that not too much work is dumped on a single person (or just a handful). I can help you, but I cannot do the work for you.

If you are no longer interested in this PR, close it.

@kyagi

kyagi commented Jun 27, 2019

Copy link
Copy Markdown
Author

@dscho Certainly. Then, let me make a new push to describe it. Thank you for your help. :-)

@dscho

dscho commented Sep 11, 2019

Copy link
Copy Markdown
Member

Then, let me make a new push to describe it.

I look forward to seeing it!

@kyagi

kyagi commented Sep 17, 2019

Copy link
Copy Markdown
Author

Sorry for the delay. New push is #647

@dscho

dscho commented Sep 17, 2019

Copy link
Copy Markdown
Member

Is #647 superseding this here PR? If so, please close the latter.

FWIW you could also update this PR by force-pushing the branch. But since you already opened a new PR...

@dscho

dscho commented Oct 9, 2019

Copy link
Copy Markdown
Member

Is #647 superseding this here PR? If so, please close the latter.

It would appear so. Here, I'll close it for you.

@dscho dscho closed this Oct 9, 2019
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Sep 29, 2021
Sparse index: integrate with `clean` and `stash -u`
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Nov 2, 2021
Sparse index: integrate with `clean` and `stash -u`
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Nov 10, 2021
Sparse index: integrate with `clean` and `stash -u`
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Nov 16, 2021
Sparse index: integrate with `clean` and `stash -u`
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jan 18, 2022
Sparse index: integrate with `clean` and `stash -u`
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jan 28, 2022
Sparse index: integrate with `clean` and `stash -u`
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Mar 16, 2022
Sparse index: integrate with `clean` and `stash -u`
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request May 22, 2022
Sparse index: integrate with `clean` and `stash -u`
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jun 23, 2022
Sparse index: integrate with `clean` and `stash -u`
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jun 27, 2022
Sparse index: integrate with `clean` and `stash -u`
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jul 14, 2022
Sparse index: integrate with `clean` and `stash -u`
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Sep 30, 2022
Sparse index: integrate with `clean` and `stash -u`
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Oct 4, 2022
Sparse index: integrate with `clean` and `stash -u`
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Nov 8, 2022
Sparse index: integrate with `clean` and `stash -u`
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Mar 15, 2023
Sparse index: integrate with `clean` and `stash -u`
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Mar 15, 2023
Sparse index: integrate with `clean` and `stash -u`
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request May 11, 2023
Sparse index: integrate with `clean` and `stash -u`
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Aug 23, 2023
Sparse index: integrate with `clean` and `stash -u`
vdye added a commit to vdye/git that referenced this pull request Jan 9, 2024
Sparse index: integrate with `clean` and `stash -u`
vdye added a commit to vdye/git that referenced this pull request Jan 9, 2024
Sparse index: integrate with `clean` and `stash -u`
vdye added a commit to vdye/git that referenced this pull request Jan 9, 2024
Sparse index: integrate with `clean` and `stash -u`
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Apr 30, 2024
Sparse index: integrate with `clean` and `stash -u`
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request May 31, 2024
Sparse index: integrate with `clean` and `stash -u`
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jun 19, 2024
Sparse index: integrate with `clean` and `stash -u`
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jul 19, 2024
Sparse index: integrate with `clean` and `stash -u`
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Aug 23, 2024
Sparse index: integrate with `clean` and `stash -u`
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Sep 30, 2024
Sparse index: integrate with `clean` and `stash -u`
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Oct 9, 2024
Sparse index: integrate with `clean` and `stash -u`
dscho pushed a commit to derrickstolee/git that referenced this pull request Dec 10, 2024
Sparse index: integrate with `clean` and `stash -u`
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Aug 5, 2025
Sparse index: integrate with `clean` and `stash -u`
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Sep 2, 2025
Sparse index: integrate with `clean` and `stash -u`
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Nov 7, 2025
Sparse index: integrate with `clean` and `stash -u`
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Feb 3, 2026
Sparse index: integrate with `clean` and `stash -u`
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Apr 22, 2026
Sparse index: integrate with `clean` and `stash -u`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants