Skip to content

hooks--pre-commit.sample: check chars for windows compatibility - #252

Closed
dexteritas wants to merge 1 commit into
git:masterfrom
dexteritas:patch-1
Closed

hooks--pre-commit.sample: check chars for windows compatibility#252
dexteritas wants to merge 1 commit into
git:masterfrom
dexteritas:patch-1

Conversation

@dexteritas

@dexteritas dexteritas commented Jun 13, 2016

Copy link
Copy Markdown

After the ASCII-check, test the windows compatibility of file names.
Can be disabled by:
git config hooks.allownonwindowschars true

@dexteritas
hooks--pre-commit.sample: check for chars, that are not allowed for a…
e3bbc2d 
… windows file name

After the ASCII-check, test the windows compatibility of file names.
Can be disabled by:
git config hooks.allownonwindowschars true
@dexteritas dexteritas changed the title hooks--pre-commit.sample: check for chars for windows compatibility hooks--pre-commit.sample: check chars for windows compatibility Jun 13, 2016
@koppor

koppor commented Jun 13, 2016 •
edited
Loading

Copy link
Copy Markdown

I'm not sure whether you read https://github.com/git/git

Git Source Code Mirror - This is a publish-only repository and all pull requests are ignored. Please follow Documentation/SubmittingPatches procedure for any of your improvements.

Seems, they ask for following https://github.com/git/git/blob/master/Documentation/SubmittingPatches instead of creating a pull request.

According to Preventing Pull Request in github, it is impossible to disable pull requests. - BTW: I am not a maintainer of this project, just an OSS guy interested in PRs not getting lost.

See also #137 (comment).

@pranitbauva1997

pranitbauva1997 commented Jun 14, 2016

Copy link
Copy Markdown
Contributor

@koppor Its perfectly fine to open up a PR. Due to variety of reasons people aren't able to send patches to the mailing list. We have a very useful application SubmitGit which can be used to send PR's as patches. Thanks for your contribution!

@dexteritas

dexteritas commented Jun 15, 2016

Copy link
Copy Markdown
Author

I just used SubmitGit to send the email. I coudn't use it earlier, because there is the requirement to be registered at least one day and I registered just yesterday.

@dexteritas dexteritas closed this Jun 15, 2016
@pranitbauva1997

pranitbauva1997 commented Jun 15, 2016

Copy link
Copy Markdown
Contributor

@dexteritas missing signoff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

3 participants

@dexteritas @koppor @pranitbauva1997