Skip to content

Make stash a builtin - #191

Closed
rimrul wants to merge 2 commits into
git:masterfrom
rimrul:upstream-stash-builtin
Closed

Make stash a builtin#191
rimrul wants to merge 2 commits into
git:masterfrom
rimrul:upstream-stash-builtin

Conversation

@rimrul

@rimrul rimrul commented Jan 21, 2016

Copy link
Copy Markdown
Contributor

These are the first two Patches in an upcomming series of Patches to
convert git stash into a builtin command. This is mainly based on the
general performance of scripts running inside an interpreter (bash in
this case) running inside a POSIX emulation layer on Windows. Shell,
perl and python scripts are generaly a lot faster on Unix-like systems
compared to Windows systems. That does not mean that Unix-like systems
won't benefit from more native Git commands, but the effect is bigger
on Git for Windows.

These two patches port over the core non-patch part of git-stash into
native code using a separate helper command. This helper command is
intended as a temporary meassure and as such it's subject to change.
For this reason, I did not implement new regression tests, documentation
or localizations for this command.

I meassured the changes in excecution time for the stash related
regression tests on the same hardware running Windows 8.1 and
Kubuntu 15.10. Each result is the difference between the average of five
meassurements (six on Linux, because I lost count on the first run of
meassurements) each before and after these changes. I meassured the
following changes:

Windows:

t3903
real -5,10%
user -0,94%
sys +0,16% (10ms)

t3904
real -0,30%
user -2,98% (20ms)
sys +5,03%

t3905
real -4,03%
user -8,13%
sys +17,42%

t3906
real -2,57%
user +1,94%
sys +1,59%

Linux:

t3903
real +0,63%
user +10,87% (3ms)
sys +4,29% (4ms)

t3904
real -7,29%
user -30,61%
sys +5,77% (4ms)

t3905
real -7,29%
user -33,33% (2ms)
sys +20% (2ms)

t3906
real -0,88%
user -1,08% (1ms)
sys -2,22%

I added the asolute times where I think the difference is below the
meassurement precission (4ms on Linux) and on the two lowest absolute
differences on windows. A full log of all meassurement runs is available
at https://gist.github.com/rimrul/82adf3b368ed633263d2. Please note that
according to Johannes Schindelin, maintainer of Git for Windows, the
meassuring of sys time on Windows is unreliable. With that in mind,
in summary this is a slight increase in performance on Linux, and a more
noticeable increase on Windows.

@rimrul rimrul mentioned this pull request Jan 21, 2016
Closed
@rimrul
rimrul force-pushed the upstream-stash-builtin branch 2 times, most recently from d1893d9 to 0027f17 Compare January 27, 2016 13:06
peff referenced this pull request Jan 27, 2016
@larsxschneider @peff
Add Travis CI support
522354d 
The tests are currently executed on "Ubuntu 12.04 LTS Server Edition
64 bit" and on "OS X Mavericks" using gcc and clang.

Perforce and Git-LFS are installed and therefore available for the
respective tests.

Signed-off-by: Lars Schneider <[email protected]>
Signed-off-by: Jeff King <[email protected]>
@submitgit

submitgit commented Jan 28, 2016

Copy link
Copy Markdown
Member

@rimrul sent these 2 commits (d10e2cb...0027f17) as a set of patches to the mailing list with submitGit - here on Gmane, MARC

@submitgit

submitgit commented Jan 28, 2016

Copy link
Copy Markdown
Member

@rimrul sent these 2 commits (d10e2cb...0027f17) as a set of patches to the mailing list with submitGit - here on Gmane, MARC

@submitgit

submitgit commented Jan 28, 2016

Copy link
Copy Markdown
Member

@rimrul sent these 2 commits (d10e2cb...0027f17) as a set of patches to the mailing list with submitGit - here on Gmane, MARC

@rimrul

rimrul commented Jan 28, 2016

Copy link
Copy Markdown
Contributor Author

The pull request has reached the mailing list after some trouble related to rtyley/submitgit#23.

rimrul added 2 commits April 2, 2016 15:09
@rimrul
stash--helper: implement "git stash--helper"
ad1dcff 
This patch implements a new "git stash--helper" builtin plumbing
command that will be used to migrate "git-stash.sh" to C.

We start by implementing only the "--non-patch" option that will
handle the core part of the non-patch stashing.

Signed-off-by: Matthias Aßhauer <[email protected]>
@rimrul
stash: use "stash--helper"
b527dfb 
Use the new "git stash--helper" builtin. It should be faster than the old shell code and is a first step to move
more shell code to C.

Signed-off-by: Matthias Aßhauer <[email protected]>
@rimrul
rimrul force-pushed the upstream-stash-builtin branch 2 times, most recently from e104501 to b527dfb Compare April 2, 2016 17:24
carlosmn pushed a commit to carlosmn/git that referenced this pull request Oct 26, 2016
@peff
Merge pull request git#191 from github/peff/daemon-sockstat-config
b850f98 
git-daemon: accept config options from the remote
@dscho

dscho commented Jun 4, 2019

Copy link
Copy Markdown
Member

I guess this can be closed, now that a built-in stash is on its way to v2.22.0?

@rimrul

rimrul commented Jun 4, 2019

Copy link
Copy Markdown
Contributor Author

Yes, I agree

@rimrul rimrul closed this Jun 4, 2019
@rimrul

rimrul commented Jun 4, 2019

Copy link
Copy Markdown
Contributor Author

Oh, yes, I should've closed this back in April 2018 along with git-for-windows#508

@dscho

dscho commented Jun 4, 2019

Copy link
Copy Markdown
Member

:-)

derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Oct 4, 2019
@jeffhostetler
Merge pull request git#191 from jeffhostetler/sc223-gvfs-helper
8f53588 
gvfs-helper: create tool to fetch objects using the GVFS Protocol
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jun 2, 2020
@jeffhostetler @derrickstolee
Merge first wave of gvfs-helper feature
b098b57 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Aug 3, 2020
@jeffhostetler @derrickstolee
Merge first wave of gvfs-helper feature
d2e6d5d 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Nov 3, 2020
@jeffhostetler @derrickstolee
Merge first wave of gvfs-helper feature
8d38f0f 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Dec 23, 2020
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
0efc144 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit to derrickstolee/git that referenced this pull request Dec 24, 2020
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
744a276 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Dec 29, 2020
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
dc48de4 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Mar 19, 2021
@jeffhostetler
Merge first wave of gvfs-helper feature
8f70ba6 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Aug 10, 2021
@jeffhostetler @derrickstolee
Merge first wave of gvfs-helper feature
5c6721d 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Aug 15, 2021
@jeffhostetler @derrickstolee
Merge first wave of gvfs-helper feature
7954a45 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Aug 17, 2021
@jeffhostetler @derrickstolee
Merge first wave of gvfs-helper feature
b013f94 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Nov 2, 2021
@jeffhostetler @derrickstolee
Merge first wave of gvfs-helper feature
d3cfbd0 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Mar 16, 2022
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
bd26e4f 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request May 22, 2022
@jeffhostetler @vdye
Merge first wave of gvfs-helper feature
fce4682 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jun 23, 2022
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
11378bf 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jun 27, 2022
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
09f4709 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jul 14, 2022
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
183a0e0 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Sep 30, 2022
@jeffhostetler @derrickstolee
Merge first wave of gvfs-helper feature
6fc8360 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Oct 4, 2022
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
ebcbccf 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Nov 8, 2022
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
c3fa11b 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Mar 15, 2023
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
87de89d 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Mar 15, 2023
@jeffhostetler @derrickstolee
Merge first wave of gvfs-helper feature
4956dae 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request May 11, 2023
@jeffhostetler @derrickstolee
Merge first wave of gvfs-helper feature
b61f3d5 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Aug 23, 2023
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
f60db9a 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
vdye pushed a commit to vdye/git that referenced this pull request Jan 9, 2024
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
93da4f0 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
vdye pushed a commit to vdye/git that referenced this pull request Jan 9, 2024
@jeffhostetler @vdye
Merge first wave of gvfs-helper feature
94e6d0a 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
vdye pushed a commit to vdye/git that referenced this pull request Jan 9, 2024
@jeffhostetler @derrickstolee
Merge first wave of gvfs-helper feature
0b30c5f 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
vdye pushed a commit to vdye/git that referenced this pull request Jan 9, 2024
@jeffhostetler @vdye
Merge first wave of gvfs-helper feature
0079a57 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
vdye pushed a commit to vdye/git that referenced this pull request Jan 9, 2024
@jeffhostetler @derrickstolee
Merge first wave of gvfs-helper feature
56ca8a8 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Apr 30, 2024
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
49c0b35 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request May 31, 2024
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
7c00e70 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jun 19, 2024
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
a5d4c1d 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jul 19, 2024
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
c8678c6 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Aug 23, 2024
@jeffhostetler @mjcheetham
Merge first wave of gvfs-helper feature
aaf8ae1 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Sep 30, 2024
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
fb4acab 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Oct 9, 2024
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
c06e60c 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit to derrickstolee/git that referenced this pull request Dec 10, 2024
@jeffhostetler @mjcheetham
Merge first wave of gvfs-helper feature
b546376 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Aug 5, 2025
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
3bda4ed 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Sep 2, 2025
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
659cd12 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Nov 7, 2025
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
8c6d05b 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Feb 3, 2026
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
52d7280 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Apr 22, 2026
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
abc1e59 
Includes commits from these pull requests:

	git#191
	git#205
	git#206
	git#207
	git#208
	git#215
	git#220
	git#221

Signed-off-by: Derrick Stolee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

3 participants

@rimrul @submitgit @dscho