include final slash in ~/.zsh/_git/ - #137

Hi @durantschoon. At the moment, the Git project unfortunately does not accept patches by pull request - you have to send them to the mailing list. The process for doing this is surprising involved - the fact that the process is so unfamiliar & fiddly for the majority of Git users was a problem discussed at the Git Contributors conference about a month ago. We weren't able to reach agreement on a change, but a suggestion was made that perhaps a bridge could be created from GitHub pull requests to the mailing list.

This is what I'm trying to do. So, I'm really glad you've opened this PR, because I'd like you to try out the new service, called submitGit.

You login to the service using GitHub OAuth, select your PR, get submitGit to send it to you in order to check it looks ok, then, when you're ready, get submitGit to send it on to the mailing list.

You would be the first person to use the service for real, and I'd appreciate your feedback. Bear in mind there are a couple of things wrong with your submission (commit message line length longer than 72 chars, and no signed-off-by at the end), so you'd need to fix those before sending them to the mailing list (obviously, they're things that submitGit should, and eventually will, warn you about).

Let me know what you think - or if you prefer the current submission process, that would really interest me.

thanks,
Roberto

Incidentally, I'm a developer at the Guardian, and do a bit of Git stuff - nice to meet you

@rtyley
Perhaps submitGit can gain a feature where trusted users or reviewers can send out e-mails on other people's behalf, as long as the original contributor signed-off the patch correctly already in their commit?

I do not know if this commit is signed-off (or GitHub UI hiding it), so the above may not apply to
this one, though.

Perhaps submitGit can gain a feature where trusted users or reviewers can send out e-mails on other people's behalf, as long as the original contributor signed-off the patch correctly already in their commit?

@gitster I think it's probably best that we encourage people to submit their own PRs to the list (rather than have trusted reviewers adopt them), even if they are signed-off - hopefully there shouldn't be any reason why PR creators can't do that?

Abandonment is sad, but what we could do regarding that is this: add a webhook callback to the git/git GitHub repository settings, firing whenever a pull request is opened - it would just trigger submitGit to immediately make a guiding comment on the PR, leading the user to https://submitgit.herokuapp.com/, so they can correctly submit the change while still focused on the task.

I do not know if this commit is signed-off (or GitHub UI hiding it), so the above may not apply to
this one, though.

This one's not signed off as it happens, you can see the full text of the commit (which is a different field to the pull request description, tho' the PR desc defaults to using the text of the commit message) here: durantschoon@0f19473 ... GitHub doesn't hide any kind of footer, including 'Signed-off-by', thankfully.

To be honest, I passionately hate using mailing lists. Especially if I have to subscribe to the list to post to it. Especially if I submit a small patch somewhere chances are good that I do not care about all the unrelated development discussion, "pull requests", etc. happening on that list. So I can understand everyone who prefers a quick GitHub PR over the hassle of submitting a patch on a mailing list.

hassle of submitting a patch on a mailing list.

git format-patch HEAD^1
git send-email --to="[email protected]" *.patch

Where is the hassle? It is even faster than creating such pull requests, where I am supposed to create a fork and hit the green "pull request button" in the web interface…

…and you don't need to subscribe to the mailing list; just send your patch. It's two commands. :)

What configuration does git send-email need? I don't believe git can send email by itself since it's not an SMTP client.

a sendmail-style tool i guess

in your .gitconfig:

[sendemail]
    smtpencryption = tls
    smtpserver = smtp.myserver.com
    smtpuser = [email protected]
    smtpserverport = 587

+ThiefMaster

You don't have to subscribe to the mailing list to send patches (at least for git mailing list this is true).
Also that's the whole point of the submitGit app so you can do a pull request and the app turns it into a proper mailing list submission.

@durantschoon I see that all these years later, this patch would still apply.

Please wrap your commit message to <=76 columns per line, add your sign off and send the patch to the mailing list for review. You can use GitGitGadget, submitGit or send it manually.

Closing this, hopefully #609 will take it's place.

its