Repository navigation
meta: Update AGENTS.md - #8077
Merged
Merged
Conversation
sentrivana
marked this pull request as ready for review
October 20, 2026 14:30
Contributor
Coverage Results 📊✅ 133905 passed | ⏭️ 7294 skipped | Total: 141199 | Pass Rate: 94.83% | Execution Time: 436m 54s 📊 Comparison with Base Branch
➖ Removed Tests (58)View removed tests
All tests are passing successfully. ✅ Patch coverage is 100.00% (no changed executable lines found; target 80%). Generated by Coverage Action |
pabloDeputter
approved these changes
Oct 20, 2026
pabloDeputter
left a comment
pabloDeputter
left a comment
Member
There was a problem hiding this comment.
LGTM 🚀; left a comment on the testing guidelines
|
|
||
| ## Test Guidelines | ||
|
|
||
| - Use end-to-end tests, not mocks. |
Member
There was a problem hiding this comment.
Not really sure about this, but I found that I constantly need to guide the agent when clanking tests, so maybe adding some more guidelines on this would be nice.
These are the most common for me (some of these are probably too specific and depend on what you're testing):
- avoid testing integration helpers or private methods directly
- avoid testing things that can't realistically break
- avoid duplicating tests (extend an existing one or use parametrize)
- assert on what sentry captures with capture_events/capture_items.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update with more specific instructions on how to do things in order to increase the reviewability and maintainability of the produced changes.
Also removed the Key Paths section as agents are quite adept at grepping and figuring out where what lives.