Skip to content

ref(graphene): Drop support for send_default_pii - #7697

Merged
sentrivana merged 1 commit into
major/3.0from
ivana/major/drop-pii-graphene
Sep 24, 2026
Merged

ref(graphene): Drop support for send_default_pii#7697
sentrivana merged 1 commit into
major/3.0from
ivana/major/drop-pii-graphene

Conversation

@sentrivana

@sentrivana sentrivana commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@linear-code

linear-code Bot commented Sep 24, 2026

Copy link
Copy Markdown

PY-2823

@sentrivana
sentrivana marked this pull request as ready for review September 24, 2026 09:39
@sentrivana
sentrivana requested a review from a team as a code owner September 24, 2026 09:39
@github-actions

github-actions Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 64288 passed | ❌ 1 failed | ⏭️ 2899 skipped | Total: 67188 | Pass Rate: 95.68% | Execution Time: 181m 38s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -70518
Passed Tests 📉 -66296
Failed Tests 📈 +1
Skipped Tests 📉 -4223

➕ New Tests (1)

View new tests
  • test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
    • Status: ❌ Failing

❌ Failed Tests

test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]

File: tests.integrations.mistral.test_mistral
Suite: py3.10-mistral-v2.0.5
Error: KeyError: 139656471851008

Stack Trace 
tests/integrations/mistral/test_mistral.py:380: in test_input_attributes_nonstreaming_chat
    sentry_init(
tests/conftest.py:349: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:278: in __init__
    self._init_impl()
sentry_sdk/client.py:428: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:216: in setup_integrations
    for integration_cls in iter_default_integrations(
sentry_sdk/integrations/__init__.py:44: in iter_default_integrations
    yield getattr(import_module(module), cls)
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1024: in _find_and_load
    ???
<frozen importlib._bootstrap>:171: in __enter__
    ???
<frozen importlib._bootstrap>:123: in acquire
    ???
E   KeyError: 139656471851008

✅ Patch coverage is 100.00%. Project has 2072 uncovered lines.
❌ Project coverage is 90.13%. Comparing base (09c4701) to head (1fbbd9c).

Coverage diff 
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.22%    90.13%    -0.09%
==========================================
  Files          194       178       -16
  Lines        25997     20989     -5008
  Branches      9662      7572     -2090
==========================================
+ Hits         23454     18917     -4537
- Misses        2543      2072      -471
- Partials      1451      1192      -259

Generated by Codecov Action

@sentrivana
sentrivana merged commit b5b96b8 into major/3.0 Sep 24, 2026
145 of 147 checks passed
@sentrivana
sentrivana deleted the ivana/major/drop-pii-graphene branch September 24, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pabloDeputter pabloDeputter pabloDeputter approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

2 participants

@sentrivana @pabloDeputter