Skip to content

ref(falcon): Drop send_default_pii support - #7695

Open
pabloDeputter wants to merge 1 commit into
major/3.0from
pablo/falcon-drop-pii
Open

ref(falcon): Drop send_default_pii support#7695
pabloDeputter wants to merge 1 commit into
major/3.0from
pablo/falcon-drop-pii

Conversation

@pabloDeputter

@pabloDeputter pabloDeputter commented Sep 24, 2026

Copy link
Copy Markdown
Member

Description

  • PyramidRequestExtractor inherits from RequestExtractor which still has some send_default_pii branching, but this will be fixed in Remove send_default_pii from wsgi #7616; same for SentryWsgiMiddleware.

Issues

Resolves #7650

@github-actions

github-actions Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 64360 passed | ❌ 1 failed | ⏭️ 2899 skipped | Total: 67260 | Pass Rate: 95.69% | Execution Time: 184m 47s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -66733
Passed Tests 📉 -62479
Failed Tests 📉 -1
Skipped Tests 📉 -4253

➕ New Tests (1)

View new tests
  • test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
    • Status: ❌ Failing

➖ Removed Tests (1)

View removed tests
  • test_binary_content_encoding_mixed_content[False-False]
    • File: tests.integrations.litellm.test_litellm

❌ Failed Tests

test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]

File: tests.integrations.mistral.test_mistral
Suite: py3.10-mistral-v2.0.5
Error: KeyError: 139909324918784

Stack Trace 
tests/integrations/mistral/test_mistral.py:380: in test_input_attributes_nonstreaming_chat
    sentry_init(
tests/conftest.py:349: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:278: in __init__
    self._init_impl()
sentry_sdk/client.py:428: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:216: in setup_integrations
    for integration_cls in iter_default_integrations(
sentry_sdk/integrations/__init__.py:44: in iter_default_integrations
    yield getattr(import_module(module), cls)
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1024: in _find_and_load
    ???
<frozen importlib._bootstrap>:171: in __enter__
    ???
<frozen importlib._bootstrap>:123: in acquire
    ???
E   KeyError: 139909324918784

✅ Patch coverage is 100.00%. Project has 2072 uncovered lines.
❌ Project coverage is 90.13%. Comparing base (09c4701) to head (554868a).

Coverage diff 
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.22%    90.13%    -0.09%
==========================================
  Files          194       178       -16
  Lines        25997     20999     -4998
  Branches      9662      7582     -2080
==========================================
+ Hits         23454     18927     -4527
- Misses        2543      2072      -471
- Partials      1451      1193      -258

Generated by Codecov Action

@pabloDeputter
pabloDeputter marked this pull request as ready for review September 24, 2026 14:16
@pabloDeputter
pabloDeputter requested a review from a team as a code owner September 24, 2026 14:16

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentrivana sentrivana sentrivana approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

2 participants

@pabloDeputter @sentrivana