Skip to content

ref(clickhouse): Drop support for send_default_pii - #7683

Merged
sentrivana merged 3 commits into
major/3.0from
ivana/major/drop-pii-clickhouse
Sep 23, 2026
Merged

ref(clickhouse): Drop support for send_default_pii#7683
sentrivana merged 3 commits into
major/3.0from
ivana/major/drop-pii-clickhouse

Conversation

@sentrivana

@sentrivana sentrivana commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

@linear-code

linear-code Bot commented Sep 23, 2026

Copy link
Copy Markdown

PY-2812

@sentrivana
sentrivana marked this pull request as ready for review September 23, 2026 13:08
@sentrivana
sentrivana requested a review from a team as a code owner September 23, 2026 13:08
@github-actions

github-actions Bot commented Sep 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 65246 passed | ❌ 1 failed | ⏭️ 2971 skipped | Total: 68218 | Pass Rate: 95.64% | Execution Time: 187m 2s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -69488
Passed Tests 📉 -65338
Failed Tests 📈 +1
Skipped Tests 📉 -4151

➕ New Tests (1)

View new tests
  • test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
    • Status: ❌ Failing

❌ Failed Tests

test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]

File: tests.integrations.mistral.test_mistral
Suite: py3.10-mistral-v2.0.5
Error: KeyError: 140510666670080

Stack Trace 
tests/integrations/mistral/test_mistral.py:380: in test_input_attributes_nonstreaming_chat
    sentry_init(
tests/conftest.py:349: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:278: in __init__
    self._init_impl()
sentry_sdk/client.py:428: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:216: in setup_integrations
    for integration_cls in iter_default_integrations(
sentry_sdk/integrations/__init__.py:44: in iter_default_integrations
    yield getattr(import_module(module), cls)
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1024: in _find_and_load
    ???
<frozen importlib._bootstrap>:171: in __enter__
    ???
<frozen importlib._bootstrap>:123: in acquire
    ???
E   KeyError: 140510666670080

✅ Patch coverage is 100.00%. Project has 2070 uncovered lines.
❌ Project coverage is 90.18%. Comparing base (e5880eb) to head (cb46707).

Coverage diff 
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.22%    90.18%    -0.04%
==========================================
  Files          194       180       -14
  Lines        25997     21076     -4921
  Branches      9662      7596     -2066
==========================================
+ Hits         23454     19006     -4448
- Misses        2543      2070      -473
- Partials      1451      1198      -253

Generated by Codecov Action

@sentrivana
sentrivana merged commit 03253ee into major/3.0 Sep 23, 2026
141 of 143 checks passed
@sentrivana
sentrivana deleted the ivana/major/drop-pii-clickhouse branch September 23, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexander-alderman-webb alexander-alderman-webb alexander-alderman-webb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

2 participants

@sentrivana @alexander-alderman-webb