Skip to content

ref(openai-agents): Remove handoff spans - #7564

Merged
alexander-alderman-webb merged 3 commits into
major/3.0from
webb/openai-agents/remove-handoff-span-2
Sep 23, 2026
Merged

ref(openai-agents): Remove handoff spans#7564
alexander-alderman-webb merged 3 commits into
major/3.0from
webb/openai-agents/remove-handoff-span-2

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Sep 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Remove handoff spans since the product does not support them.

Remove test_handoff_span() and test_max_turns_before_handoff_span() since they only have assertions on handoff spans.

Issues

Reminders

@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review September 22, 2026 08:15
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner September 22, 2026 08:15
@github-actions

github-actions Bot commented Sep 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 64438 passed | ❌ 1 failed | ⏭️ 2899 skipped | Total: 67338 | Pass Rate: 95.69% | Execution Time: 183m 58s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -69563
Passed Tests 📉 -65315
Failed Tests 📈 +1
Skipped Tests 📉 -4249

➕ New Tests (1)

View new tests
  • test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
    • Status: ❌ Failing

❌ Failed Tests

test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]

File: tests.integrations.mistral.test_mistral
Suite: py3.10-mistral-v2.0.5
Error: KeyError: 140594850971648

Stack Trace 
tests/integrations/mistral/test_mistral.py:380: in test_input_attributes_nonstreaming_chat
    sentry_init(
tests/conftest.py:349: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:278: in __init__
    self._init_impl()
sentry_sdk/client.py:428: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:216: in setup_integrations
    for integration_cls in iter_default_integrations(
sentry_sdk/integrations/__init__.py:44: in iter_default_integrations
    yield getattr(import_module(module), cls)
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1024: in _find_and_load
    ???
<frozen importlib._bootstrap>:171: in __enter__
    ???
<frozen importlib._bootstrap>:123: in acquire
    ???
E   KeyError: 140594850971648

✅ Patch coverage is 100.00%. Project has 2070 uncovered lines.
❌ Project coverage is 90.13%. Comparing base (e9ab737) to head (dfb7063).

Coverage diff 
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.21%    90.13%    -0.08%
==========================================
  Files          194       178       -16
  Lines        25997     20983     -5014
  Branches      9662      7574     -2088
==========================================
+ Hits         23454     18913     -4541
- Misses        2543      2070      -473
- Partials      1451      1191      -260

Generated by Codecov Action

Base automatically changed from webb/openai-agents/remove-handoff-span to major/3.0 September 23, 2026 14:02
@alexander-alderman-webb
alexander-alderman-webb merged commit b2d5572 into major/3.0 Sep 23, 2026
144 of 145 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/openai-agents/remove-handoff-span-2 branch September 23, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentrivana sentrivana sentrivana approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

2 participants

@alexander-alderman-webb @sentrivana