fix(dedupe): Track seen exceptions via attribute instead of ContextVar - #7533
Open
ericapisani wants to merge 6 commits into
Open
ericapisani wants to merge 6 commits into
ericapisani wants to merge 6 commits into
Conversation
Contributor
Codecov Results 📊✅ 66097 passed | ⏭️ 2999 skipped | Total: 69096 | Pass Rate: 95.66% | Execution Time: 188m 32s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2074 uncovered lines. Coverage diff@@ Coverage Diff @@
## master #PR +/-##
==========================================
- Coverage 90.28% 90.09% -0.19%
==========================================
Files 193 179 -14
Lines 25729 20923 -4806
Branches 9496 7522 -1974
==========================================
+ Hits 23228 18849 -4379
- Misses 2501 2074 -427
- Partials 1432 1180 -252Generated by Codecov Action |
ericapisani
changed the title
ericapisani
marked this pull request as ready for review
September 18, 2026 19:10
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 900ad90. Configure here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace DedupeIntegration's weakref/ContextVar-based "last seen"
tracking with a
_handled_by_sentryflag set directly on theexception. This avoids the contextvar leaking across async contexts
and removes the need for
reset_last_seen(), which the client usedto call after
before_senddropped an exception.Add a regression test for the case where the same exception instance
is re-raised (e.g. Django re-raising in middleware after a view
already handled it) to confirm it's still deduped correctly.
Fixes PY-2381
Fixes #6094