fix(serializer): Add type annotations to databag limits - #7505
Merged
sentrivana merged 1 commit intoSep 15, 2026
Merged
Conversation
Annotate MAX_DATABAG_DEPTH and MAX_DATABAG_BREADTH as int so type checkers such as ty don't infer them as Literal types and flag user reassignments as invalid. Fixes getsentry#7503
8rulerstar
marked this pull request as ready for review
September 15, 2026 08:45
sentrivana
approved these changes
Sep 15, 2026
Contributor
|
Thanks @8rulerstar! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
intannotations toMAX_DATABAG_DEPTHandMAX_DATABAG_BREADTHinserializer.py.Without them, ty infers the variables as
Literal[5]/Literal[10]and reportsinvalid-assignmentwhen users reassign them (e.g.sentry_sdk.serializer.MAX_DATABAG_DEPTH = 15). I checked this with ty locally: the errors go away after this change. No runtime change.As discussed in the issue,
MAX_EVENT_BYTESis left as is.This is my first open source contribution ever, so thanks @sentrivana for the quick reply on the issue, and I'm happy to make any changes if needed!
Issues