fix(dedupe): Make DedupeIntegration more memory efficient.#4446
Closed
antonpirker wants to merge 11 commits intomasterfrom
Closed
fix(dedupe): Make DedupeIntegration more memory efficient.#4446antonpirker wants to merge 11 commits intomasterfrom
DedupeIntegration more memory efficient.#4446antonpirker wants to merge 11 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4446 +/- ##
==========================================
- Coverage 84.60% 84.58% -0.02%
==========================================
Files 158 158
Lines 16463 16463
Branches 2850 2850
==========================================
- Hits 13928 13926 -2
- Misses 1694 1696 +2
Partials 841 841
|
antonpirker
changed the title
DedupeIntegration more memory efficient.
Member
|
@antonpirker can't you just |
Contributor
Author
|
i thought about that too. but garbage collection moves objects around. so id(exc) could be different when we safe it and when we compare it... |
sl0thentr0py
requested changes
Jun 5, 2025
Contributor
Author
|
The |
antonpirker
changed the title
DedupeIntegration more memory efficient.DedupeIntegration more memory efficient.
Contributor
Author
|
I will close this in favor of #4809 Reason: Python reuses memory addresses after garbage collection. Making this path unreliable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users reported that the
DedupeIntegrationcan use up a lot of memory, because it keeps a full exception in memory for checking if it has seen this exception already.Depending on the users code those exception objects can be big because they also include the traceback and local variables (which can be huge).
Idea is now to not save the whole exception but just a hash of the important parts of the exception to decide if we have seen this exception again.
fixes #3165
fixes #4327