fix: Clear breadcrumbs before new tx#297
Merged
Conversation
dimrozakis
added a commit
to advantis-io/sentry-dramatiq
that referenced
this pull request
Apr 13, 2020
During process startup, several things may get logged (for example by imports) and subsequently get collected by sentry as breadcrumbs. Since breadcrumbs are inherited in nested scopes, any task that raises a sentry error will include breadcrumbs since the process started. This commit ensures that each task's sentry scope is started without any preexisting breadcrumbs. It adds a test that fails without the change that clears the scope's breadcrumbs. Related issue & PR in sentry's SDK: - getsentry/sentry-python#207 - getsentry/sentry-python#297
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #207