fix(serializer): Make sentry_repr dunder method to avoid mock problems#1364
Merged
sl0thentr0py merged 5 commits intomasterfrom Mar 8, 2022
Merged
fix(serializer): Make sentry_repr dunder method to avoid mock problems#1364sl0thentr0py merged 5 commits intomasterfrom
sl0thentr0py merged 5 commits intomasterfrom
Conversation
untitaker
approved these changes
Mar 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The addition of
sentry_reprin #1322 breaksMagicMocksince it creates attrs on the fly.This converts it to a dunder magic method
__sentry_repr__.See here that mock doesn't mess with custom magics and the following test code: