fix(serializer): Implement abstract base class for customizing serialization#1363
Closed
sl0thentr0py wants to merge 3 commits intomasterfrom
Closed
fix(serializer): Implement abstract base class for customizing serialization#1363sl0thentr0py wants to merge 3 commits intomasterfrom
sl0thentr0py wants to merge 3 commits intomasterfrom
Conversation
…ing getattr directly since it breaks MagicMock
Member
Author
|
closing in favour of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The addition of
sentry_reprin #1322 breaksMagicMocksince it creates attrs on the fly.This adds a new ABC mixin class called
SentryReprMixinwhich the user has to inherit and implement thesentry_reprmethod to customize serialization instead of directly implementing it on their class.