feat(serializer): Allow classes to short circuit serializer with sentry_repr#1322
Merged
sl0thentr0py merged 1 commit intomasterfrom Jan 26, 2022
Merged
feat(serializer): Allow classes to short circuit serializer with sentry_repr#1322sl0thentr0py merged 1 commit intomasterfrom
sentry_repr#1322sl0thentr0py merged 1 commit intomasterfrom
Conversation
This was referenced Jan 26, 2022
This was referenced Mar 7, 2022
Member
Author
|
@vmarkovtsev heads up, I had to change it to |
Contributor
|
Thank you for the update, very helpful! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the discussion in #1300 and #1296.
We do a lot of truncation magic in our serializer to not send huge payloads.
In the process, we ignore if a user/framework sets a custom
__repr__on a class.This PR lets users add a
sentry_reprthat will short circuit our truncation logic and pick the user defined repr.We cannot just go with checking if
__repr__is overridden because we still want to preserve the truncation behavior for classes out there in the wild likeQueryDict.Some notes from the TSC: