fix(aws-lambda): Change lambda function handler name to 'x.y'#1107
Merged
ahmedetefy merged 1 commit intomasterfrom May 6, 2021
Merged
fix(aws-lambda): Change lambda function handler name to 'x.y'#1107ahmedetefy merged 1 commit intomasterfrom
ahmedetefy merged 1 commit intomasterfrom
Conversation
Fix for AWS Function Handler name to be in the format of filename.function-name because passing paths as function names is giving us import errors from AWS Lambda
iker-barriocanal
approved these changes
May 6, 2021
ahmedetefy
added a commit
that referenced
this pull request
May 6, 2021
This reverts commit b7b5c03.
ahmedetefy
added a commit
that referenced
this pull request
May 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides :
filename.function-namebecausepassing paths (what we have now) as function name is giving us import errors from AWS Lambda
init_serverless_sdk.sentry_lambda_handlerCurrent Behavior:
Handler name:
sentry_sdk.integrations.init_serverless_sdk.sentry_lambda_handlerResponse from AWS
Note: Unable to replicate in backend tests that actually create real lambda functions and layers. Only able to replicate this behavior on the AWS Console