Conversation
Contributor
size-limit report 📦
|
chargome
reviewed
Sep 25, 2026
| test('connects the pageload trace to the live serving request', async ({ page }) => { | ||
| test.fail(); | ||
|
|
||
| const serverTxPromise = waitForTransaction('nextjs-16-cacheComponents', transactionEvent => { |
Member
There was a problem hiding this comment.
Just double checking, if this is prerendered during the build, we get no tx here right? Can we reflect this in the test?
| import { expect, test } from '@playwright/test'; | ||
| import { waitForTransaction } from '@sentry-internal/test-utils'; | ||
|
|
||
| // The pageload should connect to the live serving request even though the shell is prerendered |
Member
There was a problem hiding this comment.
What is a live serving request?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a test for the pageload half of the complete-trace experience under
cacheComponents: the browser pageload should share a trace with the live serving request, even though the shell is prerendered.Reference (stale-trace stitching): #18176
The trace context should not be added to the cachable HTML.
Currently in a "failed" state (
test.fail()) as trace meta tags are disabled wholesale undercacheComponentsand the pageload starts a fresh trace.Note for the switch flip: the inverse assertion in
cacheComponents.spec.ts("Prerendered shell does not stitch the pageload onto a stale trace") documents today's behavior and must be removed when this test starts passing.closes #24733
Linear https://linear.app/getsentry/issue/JS-3806/pageload-connection-test-for-cache-component-apps