Skip to content

fix(astro): Add vue to registerEsmLoaderHooks - #15352

Merged
s1gr1d merged 1 commit into
v8from
sig/astro-vue-haml
Feb 10, 2025
Merged

fix(astro): Add vue to registerEsmLoaderHooks#15352
s1gr1d merged 1 commit into
v8from
sig/astro-vue-haml

Conversation

@s1gr1d

@s1gr1d s1gr1d commented Feb 10, 2025

Copy link
Copy Markdown
Member

Makes sure that vue is not wrapped and users don't get the error $haml has already been declared

closes #13982

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm (feel free to merge anytime): We don't export * from './sdk' somewhere, right? Just wanna avoid this becoming public API :)

@s1gr1d

s1gr1d commented Feb 10, 2025

Copy link
Copy Markdown
Member Author

Only init is exported :)

export { init } from './server/sdk';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants